alidist
alidist copied to clipboard
Bump FairLogger to v2.1.0 and InfoLogger to v2.8.2
Introducing a "critical" log message severity, required to distinguish critical errors for shifter operation.
It looks like there is a genuine incompatibility between InfoLogger and the new FairLogger.
ok, I will check if it is only these two string_views or if there is more
Keep also in mind that c_str() is guaranteed to be 0 terminated, string_view is not.
waiting for https://github.com/AliceO2Group/InfoLogger/pull/95 to also bump InfoLogger here
My bad, I messed up with the include file during the test... Will fix shortly
the compiler on macOS throws a warning when using enums in switch statements (in this case fair::Severity) and not handling all of the enumerators, which is the case here (missing the case for the new critical severity introduced with this bump of FairLogger). For PR checks, we use -Werror so we get an error here. Locally on my mac, the latest O2@dev with this alidist compiles successfully, throwing only the warning.
The O2 PR to fix this is already open but needs the bump of FairLogger first: https://github.com/AliceO2Group/AliceO2/pull/13957
ping @ktf