alidist icon indicating copy to clipboard operation
alidist copied to clipboard

Bump FairLogger to v2.1.0 and InfoLogger to v2.8.2

Open ehellbar opened this issue 10 months ago • 6 comments

Introducing a "critical" log message severity, required to distinguish critical errors for shifter operation.

ehellbar avatar Feb 10 '25 15:02 ehellbar

It looks like there is a genuine incompatibility between InfoLogger and the new FairLogger.

ktf avatar Feb 10 '25 15:02 ktf

ok, I will check if it is only these two string_views or if there is more

ehellbar avatar Feb 10 '25 16:02 ehellbar

Keep also in mind that c_str() is guaranteed to be 0 terminated, string_view is not.

ktf avatar Feb 10 '25 16:02 ktf

waiting for https://github.com/AliceO2Group/InfoLogger/pull/95 to also bump InfoLogger here

ehellbar avatar Feb 11 '25 09:02 ehellbar

My bad, I messed up with the include file during the test... Will fix shortly

sy-c avatar Feb 20 '25 07:02 sy-c

the compiler on macOS throws a warning when using enums in switch statements (in this case fair::Severity) and not handling all of the enumerators, which is the case here (missing the case for the new critical severity introduced with this bump of FairLogger). For PR checks, we use -Werror so we get an error here. Locally on my mac, the latest O2@dev with this alidist compiles successfully, throwing only the warning.

The O2 PR to fix this is already open but needs the bump of FairLogger first: https://github.com/AliceO2Group/AliceO2/pull/13957

ehellbar avatar Feb 20 '25 13:02 ehellbar

ping @ktf

ehellbar avatar Mar 04 '25 07:03 ehellbar