alidist icon indicating copy to clipboard operation
alidist copied to clipboard

Bump flatbuffers and use internal flatbuffers in ONNXRuntime

Open davidrohr opened this issue 1 year ago • 8 comments

davidrohr avatar Apr 01 '24 09:04 davidrohr

ONNXRuntime does not support any newer version, and will not in the foreseeable future as they say they can anyway do this internal build.

davidrohr avatar Apr 11 '24 09:04 davidrohr

Fair enough, but why bumping it, then? Is it required to get the new GCC working? If yes, how come the internal version does work?

ktf avatar Apr 11 '24 09:04 ktf

That is a good question, I was wondering the same. For me our flatbuffers did not compile with gcc13, while the 9nnx-internal version compiled. I didn't check if they somehow fixed it. Anyhow, I don't like using a many years old version due to onnx decising they do not want to bump...

davidrohr avatar Apr 11 '24 09:04 davidrohr

@davidrohr do you understand the issue on cs8?

ktf avatar May 01 '24 13:05 ktf

@ktf : which issue on cs8?

davidrohr avatar May 01 '24 20:05 davidrohr

yesterday it was failing. maybe it was simply a glitch in the wrong package.

ktf avatar May 02 '24 05:05 ktf

Now Ubuntu fails, but it was green before. So I think it is more random ctests failing. @pzhristov : What is the status of the tests with analysis? Can we merge this?

davidrohr avatar May 02 '24 06:05 davidrohr

Yes, indeed ubuntu is unrelated.

ktf avatar May 02 '24 07:05 ktf

no longer needed with onnx bumped to 1.18

davidrohr avatar Aug 01 '24 14:08 davidrohr