alidist icon indicating copy to clipboard operation
alidist copied to clipboard

Bump flatbuffers to v23.5.26

Open martenole opened this issue 1 year ago • 3 comments

To allow for compilation with gcc 13.2 in case nothing speaks against this?

martenole avatar Jan 12 '24 10:01 martenole

Fine with me, but it does not work with ONNX, apprently...

ktf avatar Jan 12 '24 11:01 ktf

Hm, I had built only what I needed to make O2 work. Trying with ONNX seems not to work, even if I try to bump ONNX to its latest version as well. In ONNXRuntime/cmake/deps.txt its still specified that flatbuffers v1.12 is used for compilation. But that doesn't compile with gcc 13. So not sure if its possible to compile our software stack with gcc 13 at the moment including ONNX

martenole avatar Jan 12 '24 12:01 martenole

For reference, I had issues with flatbuffers in ONNXruntime on my laptop, since its version 1.12 collided somehow with my system flatbuffer version. I tried if I could bump ONNXruntime's flatbuffer, but it is not foreseen. Searching a bit in the web, some other people complained, but Microsoft decided after internal discussion not to bump flatbuffer C++ for now: https://github.com/microsoft/onnxruntime/pull/10866

Though that was 2022, but apparently still didn't change... For myself, I have not found a solution. I could not get ONNXruntime working, so I disabled it for me in alidist...

davidrohr avatar Jan 12 '24 13:01 davidrohr

superseded by other PRs

davidrohr avatar May 02 '24 13:05 davidrohr