ATO-525,ATO-496 - addig qptTgl correction to slove dEdx splitting at pt<0.5 GeV

[miranov25]

This is first version of the dEdx qPt, tgl correction:

• Done in the exactly the same way as the PileUp correction
• In default settings - when switched OFF, validated that it does not influence other corrections
• Not yet fully tested

[alibuild]

cf5500827322102894bb58cb09c723d9895289f1: approval required: 1 of @ktf (Giulio Eulisse), @shahor02 (Ruben Shahoyan), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @davidrohr (David Rohr)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[miranov25]

I made code modification. Testing results step by step now. For the LHC15o will be better to apply qPtTgl correction before pileup correction. I made pull request with modification, but for the moment I only tested that it will not harm, and correction is doing what it should. I did not test yet full chain. Mostly reading part

[alibuild]

cde7ecf4ae9e0ba3cfc12956cda38cfde250eedc: approval required: 1 of @shahor02 (Ruben Shahoyan), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @davidrohr (David Rohr), @miranov25 (Marian Ivanov); 1 of @ktf (Giulio Eulisse), @shahor02 (Ruben Shahoyan), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @davidrohr (David Rohr)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[alibuild]

2507d0e98ca8348acce1dabf3f65a6b454d323c0: approval required: 1 of @shahor02 (Ruben Shahoyan), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @davidrohr (David Rohr), @miranov25 (Marian Ivanov); 1 of @ktf (Giulio Eulisse), @shahor02 (Ruben Shahoyan), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @davidrohr (David Rohr)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[chiarazampolli]

Hello @miranov25 , @wiechula

This is still not merged. Do we need it for the new corrections? Is this relevant only for 15o, so not urgent? Do you plan to do more testing?

Chiara

[miranov25]

Hello @wiechula

Did you have time to check the code, or should I commissioned application and reading part?

• For sure we need the commit
• It does not affect negatively other code
• Not yet tested for correction
  • I was waiting for somebody to join hands on session but I did not see enthusiasm within calibration group
  • -> I will have to finish it myself without witnesses

Marian

[alibuild]

07321169801039da45723c4c553aee58b2d2fbdd: approval required: 1 of @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov); 1 of @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @qgp (Jochen Klein), @pzhristov (Peter Hristov), @sawenzel (Sandro Christian Wenzel)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[pzhristov]

+test

[alibuild]

07321169801039da45723c4c553aee58b2d2fbdd: testing approved: will not be automatically merged; starting testing. If testing succeeds, merging will require further approval from 1 of @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov); 1 of @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @qgp (Jochen Klein), @pzhristov (Peter Hristov), @sawenzel (Sandro Christian Wenzel)

[alibuild]

07321169801039da45723c4c553aee58b2d2fbdd: tests OK, approval required for merging: 1 of @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov); 1 of @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @qgp (Jochen Klein), @pzhristov (Peter Hristov), @sawenzel (Sandro Christian Wenzel)

Comment with +1 to merge. Please comment on the pull request: click here and comment at the bottom of the page.

[alibuild]

Error while checking build/AliRoot/release for 07321169801039da45723c4c553aee58b2d2fbdd at 2021-04-11 16:40:

sw/BUILD/AliRoot-latest/log
 80/100 Test  #31: load_library_EMCALTriggerBase ...........   Passed    0.30 sec
        Start  89: load_library_HepMC
 81/100 Test  #98: load_library_TRDgui .....................   Passed    0.29 sec
        Start  12: load_library_lhapdf_5_9_1
 82/100 Test  #77: load_library_MONITOR ....................   Passed    0.30 sec
        Start  86: load_library_EvtGenExternal
 83/100 Test  #93: load_library_AliTPCSpaceChargeBase ......   Passed    0.20 sec
        Start  90: load_library_Photos
 84/100 Test  #11: load_library_lhapdf .....................   Passed    0.17 sec
        Start  17: load_library_pythia6_4_28
 85/100 Test   #9: load_library_HIJING .....................   Passed    0.18 sec
        Start  91: load_library_Tauola
 86/100 Test  #20: load_library_pythia8243 .................   Passed    0.18 sec
        Start  81: load_library_StarLight
 87/100 Test  #15: load_library_pythia6_4_21 ...............   Passed    0.17 sec
        Start  16: load_library_pythia6_4_25
 88/100 Test  #89: load_library_HepMC ......................   Passed    0.18 sec
        Start  87: load_library_EvtGen
 89/100 Test  #12: load_library_lhapdf_5_9_1 ...............   Passed    0.18 sec
        Start  10: load_library_lhapdfbase
 90/100 Test  #86: load_library_EvtGenExternal .............   Passed    0.18 sec
        Start  21: load_library_AMPT
 91/100 Test  #90: load_library_Photos .....................   Passed    0.18 sec
        Start  13: load_library_pythia6
 92/100 Test  #17: load_library_pythia6_4_28 ...............   Passed    0.19 sec
        Start  69: load_library_AliGPUCommon
 93/100 Test  #81: load_library_StarLight ..................   Passed    0.17 sec
 94/100 Test  #91: load_library_Tauola .....................   Passed    0.18 sec
 95/100 Test  #16: load_library_pythia6_4_25 ...............   Passed    0.18 sec
 96/100 Test  #87: load_library_EvtGen .....................   Passed    0.17 sec
 97/100 Test  #10: load_library_lhapdfbase .................   Passed    0.17 sec
 98/100 Test  #21: load_library_AMPT .......................   Passed    0.18 sec
 99/100 Test  #13: load_library_pythia6 ....................   Passed    0.17 sec
100/100 Test  #69: load_library_AliGPUCommon ...............   Passed    0.17 sec

100% tests passed, 0 tests failed out of 100

Total Test time (real) =   7.43 sec
+ cp -v /mnt/mesos/sandbox/sandbox/aliroot-release/sw/BUILD/5a26c800b64a8fa297b4f6139e1a99218bba5786/AliRoot/compile_commands.json /mnt/mesos/sandbox/sandbox/aliroot-release/sw/slc7_x86-64/AliRoot/build_AliRoot_release-1
'/mnt/mesos/sandbox/sandbox/aliroot-release/sw/BUILD/5a26c800b64a8fa297b4f6139e1a99218bba5786/AliRoot/compile_commands.json' -> '/mnt/mesos/sandbox/sandbox/aliroot-release/sw/slc7_x86-64/AliRoot/build_AliRoot_release-1/compile_commands.json'
++ readlink /mnt/mesos/sandbox/sandbox/aliroot-release/sw/SOURCES/AliRoot/build_AliRoot_release/0
+ DEVEL_SOURCES=/mnt/mesos/sandbox/sandbox/aliroot-release/AliRoot
+ [[ /mnt/mesos/sandbox/sandbox/aliroot-release/AliRoot != /mnt/mesos/sandbox/sandbox/aliroot-release/sw/SOURCES/AliRoot/build_AliRoot_release/0 ]]
+ sed -i.deleteme -e 's|/mnt/mesos/sandbox/sandbox/aliroot-release/sw/SOURCES/AliRoot/build_AliRoot_release/0|/mnt/mesos/sandbox/sandbox/aliroot-release/AliRoot|' compile_commands.json
+ rm -f compile_commands.json.deleteme
+ ln -nfs /mnt/mesos/sandbox/sandbox/aliroot-release/sw/BUILD/5a26c800b64a8fa297b4f6139e1a99218bba5786/AliRoot/compile_commands.json /mnt/mesos/sandbox/sandbox/aliroot-release/AliRoot/compile_commands.json
+ rsync -a /mnt/mesos/sandbox/sandbox/aliroot-release/sw/SOURCES/AliRoot/build_AliRoot_release/0/test/ /mnt/mesos/sandbox/sandbox/aliroot-release/sw/slc7_x86-64/AliRoot/build_AliRoot_release-1/test
+ [[ RELWITHDEBINFO == COVERAGE ]]
+ mkdir -p /mnt/mesos/sandbox/sandbox/aliroot-release/sw/slc7_x86-64/AliRoot/build_AliRoot_release-1/etc/modulefiles

Full log here.

[alibuild]

69e501ed387ab54e4a2ba2561424dd224bc07983: approval required: 1 of @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov); 1 of @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @qgp (Jochen Klein), @pzhristov (Peter Hristov), @sawenzel (Sandro Christian Wenzel)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[alibuild]

aa2f9ec7829ae4f271db45e56212d2a626f98bee: approval required: 1 of @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @shahor02 (Ruben Shahoyan); 1 of @qgp (Jochen Klein), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[alibuild]

2640966503c4f5720eaf125ae6aaf2140127253c: approval required: 1 of @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @shahor02 (Ruben Shahoyan); 1 of @qgp (Jochen Klein), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[shahor02]

+test

[alibuild]

2640966503c4f5720eaf125ae6aaf2140127253c: testing approved: will not be automatically merged; starting testing. If testing succeeds, merging will require further approval from 1 of @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @shahor02 (Ruben Shahoyan); 1 of @qgp (Jochen Klein), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

[alibuild]

2640966503c4f5720eaf125ae6aaf2140127253c: tests OK, approval required for merging: 1 of @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @shahor02 (Ruben Shahoyan); 1 of @qgp (Jochen Klein), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to merge. Please comment on the pull request: click here and comment at the bottom of the page.

[alibuild]

233e21943f1d6d598d7ab0348b5e9c4531001464: approval required: 1 of @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @shahor02 (Ruben Shahoyan); 1 of @qgp (Jochen Klein), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[alibuild]

8858b3eff22930d4409224699c15ed3e00b98fb6: approval required: 1 of @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @shahor02 (Ruben Shahoyan); 1 of @qgp (Jochen Klein), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @davidrohr (David Rohr), @chiarazampolli (Chiara Zampolli), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[alibuild]

5e263cda9923f250dbf00711aba010a5e132a68c: approval required: 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @shahor02 (Ruben Shahoyan); 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[alibuild]

49e34a1d0ce96c1fa53f6b7751650b8b154c5e3b: approval required: 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @shahor02 (Ruben Shahoyan); 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[miranov25]

Hello @wiechula

I fixed some problems, now I am including modification for the high dEdx correction. Please, do not approve yet.

Regards Marian

[alibuild]

033a34f0e10c473f06bb255ad9b1a071b6460c41: approval required: 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @shahor02 (Ruben Shahoyan); 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[miranov25]

Hello @wiechula

I changed the formatting in header filed and i added static functions to correct momenta and dEdx for energy loss within TPC I did not commit yet usage of that correction. Maybe we can meet, to specify how users will speicyfy parameters needed. Free parameters:

• gas type (Argon, Neon)
• E loss scaling i respect to the nominal tabulated value for that gases ...

[alibuild]

e140dc563d006a9bb70b5d49955f60930711c1da: approval required: 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @shahor02 (Ruben Shahoyan); 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[miranov25]

Hello @wiechula

I added energy loss correction added. Please do not merge yet. I have to check full chain.

[alibuild]

c8238b3d7633ba5daf53287ef0292a8669aac885: approval required: 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein), @miranov25 (Marian Ivanov), @shahor02 (Ruben Shahoyan); 1 of @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @ktf (Giulio Eulisse), @pzhristov (Peter Hristov), @qgp (Jochen Klein), @chiarazampolli (Chiara Zampolli), @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.

[miranov25]

Fixing problem seen in Mesut jobs

• bbAleph not well defined below BG 0.05 - it could be even negative - putting to the code protection against outliers

[miranov25]

• For the functions - they were needed for the TTreeFormula evaluation
• TTreeFormula are evaluating (sending them) as doubles
• I did not pay attention to mix double/float but in some calculation like sqrt(A2-B2) the double precision is preferable to avoid numerical instabilities -- I can change it
• For the const vs normal I do not care as argument - I am not C++ fundametatlist. Variables are local _> function does not change stat in outer scope -- I can change it I suggest to meet to make modification on zoom For the moment I make changes which are needed to simplify testing

[alibuild]

2f249b4d1cff4e54e0b17f2b23ddb4d9b5e4bd9e: approval required: 1 of @miranov25 (Marian Ivanov), @shahor02 (Ruben Shahoyan), @davidrohr (David Rohr), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @qgp (Jochen Klein); 1 of @sawenzel (Sandro Christian Wenzel), @shahor02 (Ruben Shahoyan), @ktf (Giulio Eulisse), @davidrohr (David Rohr), @qgp (Jochen Klein), @jgrosseo (Jan Fiete Grosse-Oetringhaus), @chiarazampolli (Chiara Zampolli), @pzhristov (Peter Hristov)

Comment with +1 to approve and allow automatic merging,or with +test to run tests only. Please comment on the pull request: click here and comment at the bottom of the page.