Syed Ali Shahbaz

Results 193 comments of Syed Ali Shahbaz

Looks > A few things failing: > > 1. When I try to create multiple private links, say I have created 1 that expires on a certain date -> As...

> I have some UI suggestions. I think it would look cleaner if we don't show the 'Expires on' and 'Maximum number of uses' inputs and only have the gray...

> fixed, will push everything in a while! ![image](https://github.com/user-attachments/assets/4ac22b5c-c28e-43cb-823b-88e273f036c0) Can we not have the input inline like so?

> > I have some UI suggestions. I think it would look cleaner if we don't show the 'Expires on' and 'Maximum number of uses' inputs and only have the...

> alright, is this nice? I like this, deferring to @CarinaWolli for the final decision.

@retrogtx Type checks failing, I pulled it locally and I see a bunch of errors too in the `MultiplePrivateLinksController` file. Can you take a look?

@retrogtx How is this looking? Is it ready for a review again?

@saurabhraghuvanshii Thank you for this PR. Can you please provide a Loom Video of the solution as well as add a test confirming your changes work? We can't merge the...

> @alishaz-polymath in description video is added I don't see the video link in the description, only two screenshots. Am I missing something? 🤔

> > > @alishaz-polymath in description video is added > > > > > > I don't see the video link in the description, only two screenshots. Am I missing...