mobx-react-router icon indicating copy to clipboard operation
mobx-react-router copied to clipboard

build: upgrade

Open superwf opened this issue 4 years ago • 7 comments

  • rewrite source by ts.
  • compatible with mobx v6.
  • use rollup for module and cmd output.
  • add module output.
  • change declaration file path to module/index.d.ts.
  • change type,module,browser,unpkg section in package.json.
  • upgrade eslint and babel dependencies.
  • update test case.

may be it mobx-react-router should upgrade to v5.

superwf avatar Nov 09 '20 02:11 superwf

It looks like this library isn't maintained anymore. Would you like to create a separate NPM package?

kubk avatar Nov 27 '20 14:11 kubk

@kubk already published https://www.npmjs.com/package/@superwf/mobx-react-router

superwf avatar Dec 02 '20 11:12 superwf

I have tried to use this patch with Mobx6, but the UMD build in IE11 gives syntax errors. You can find the similar error in

https://github.com/react-dnd/react-dnd/issues/1557

The bundle should be transpiled to IE11 compatible using babel pre-set

See the change in rollup.config.js

https://github.com/react-dnd/react-dnd/pull/1621/commits/242a6e177405ed046ce77575921bbc001825156a

VinVinMa avatar Mar 01 '21 03:03 VinVinMa

@jimbofreedman @eduardofcgo @alisd23 can you guys check this / merge so we have MobX v6 support?

eek avatar Mar 31 '21 11:03 eek

@eek You can use the aforementioned fork for now. The original author of this library responds neither here nor to emails.

kubk avatar Mar 31 '21 12:03 kubk

@kubk I am using the other repo at the moment, but in the other issue - https://github.com/alisd23/mobx-react-router/issues/74 @alisd23 gave full access to @jimbofreedman and @eduardofcgo to keep the repo updated. Maybe he should have also given permissions to @superwf

eek avatar Mar 31 '21 12:03 eek

@eek Great, let's wait for them. I've been using this fork for the past 2 months on production and it works with no issues.

kubk avatar Mar 31 '21 14:03 kubk

@superwf you did such great work with typescript and rollback. Are you still interested in merging some of your changes?

gcattan avatar Jan 04 '23 20:01 gcattan