mobx-react-router icon indicating copy to clipboard operation
mobx-react-router copied to clipboard
verified publisher icon alisd23

Examples use decorators, but decorators are not supported.

Open josephbhunt opened this issue 8 years ago • 1 comments

While i like the fact that the examples include decorators for future javascript versions, the examples are not useful for today. Decorators are not supported in any browser right now. It would be nice to have all examples in the README written in ECMAScript 5.

josephbhunt avatar Dec 16 '17 05:12 josephbhunt

Hi there. I agree that decorators aren't actually in the ES spec yet, (actually still only stage 2). However I'm sort of trying to keep in sync with the mobx-react docs, to try and keep the documentation as similar as possible.

The mobx-react docs include decorators and es6 syntax, so maybe this would be a suitable compromise - to also show the example with es6 features only? I wouldn't want to drop back to es5 as that is pretty much entirely implemented in all the modern browsers.

alisd23 avatar Dec 18 '17 18:12 alisd23

This seems a little outdated now. Closing.

gcattan avatar Jul 13 '23 07:07 gcattan