coredis icon indicating copy to clipboard operation
coredis copied to clipboard

Refactor connections to allow early release back to connection pool

Open alisaifee opened this issue 2 years ago • 1 comments

Description

Refactoring of the request response flow to allow releasing the connection back to the connection pool if so desired. The primary objective is to allow higher concurrency with blocking connection pools.

This has a few side effects:

  • response parsing can be performed inline when the data_received callback is called
  • the pipeline implementation can possibly be simplified
  • connections can be released back to the pool very early when using the ignore_replies context manager
  • the parser implementation can be completely decoupled from the connection

alisaifee avatar Jul 28 '22 23:07 alisaifee

Codecov Report

Merging #80 (d511fc2) into master (d511fc2) will not change coverage. The diff coverage is n/a.

:exclamation: Current head d511fc2 differs from pull request most recent head c61f2c6. Consider uploading reports for the commit c61f2c6 to get more accurate results

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files          57       57           
  Lines        7227     7227           
=======================================
  Hits         7093     7093           
  Misses        134      134           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Jul 28 '22 23:07 codecov[bot]