Ali-Akber Saifee
Ali-Akber Saifee
Closing due to inactivity
> @alisaifee any chance you can look at this one? I appreciate this might not be a very high priority, but it feels like a useful abstraction to have considering...
> I added the exception handling in the strategies, thinking that it might be useful that the storages raise the underlying exceptions. This might not be the desired approach, happy...
One minor issue here is that this change will be somewhat backward incompatible (for example if someone was explicitly catching exceptions from a specific storage class - they would no...
> Besides, not sure what's going on with CI. The branch seems to be up to date with master, but the linter locally succeeds and fails in CI 🤔 Also,...
@hasier I'm going to merge this to master and perhaps tag you in a PR if I decide to make any changes from the public API perspective before making a...
@hasier I didn't end up with much changes to warrant a separate PR so have pushed straight to master. Mostly some reductions in code, typing & documentation tweaks. You can...
This is now available in [3.8.0](https://github.com/alisaifee/limits/releases/tag/3.8.0)
I don’t think I understand the issue clearly, could you provide a reproduction step?
Yes this is the expected behavior of the fixed window strategy is implemented (regardless of the storage type) - i.e. the window is constructed based on the second of the...