Alin Tomescu

Results 44 comments of Alin Tomescu

Hey @JackyWYX, I thought your last comment kind of settled it. For now, we do not want to relax the public key validation criteria, since your issue can be dealt...

The main blocker for this PR, besides @davidiw's blessing, is a generic way of estimating gas costs for any native function. Will work with @vgao1996 on that and then we...

@davidiw, this PR is ready to be approved now: - it is feature-gated - it has the (reasonable) gas costs, marked with `optional` - it bumps up the gas version...

Core logic looks good.

Thank you! Straightforward PR. I recall I wanted something like this at some point. Two thoughts: - might we want this propagated further down in `aptos_stdlib` rather than `aptos_framework`? -...

Making sure @runtian-zhou, @wrwg and @vgao1996 see this...

Thank you for the PR @blasrodri! There are two flavors of Blake: Blake2b, Blake2s (see https://www.blake2.net/). Can you please update the PR title and all of the code (e.g., function...

Thank you for the update @blasrodri! Can you include in the PR's description the performance impact of going from `blake2` crate to `blake2-rfc`?

> `blake2` seems to be faster than `blake2-rfc` > > ```rust > use blake2::{ > digest::{Update, VariableOutput}, > Blake2bVar, > }; > use criterion::{black_box, criterion_group, criterion_main, Criterion}; > > fn...