diptest icon indicating copy to clipboard operation
diptest copied to clipboard

Update of package & maintenance

Open RUrlus opened this issue 2 years ago • 1 comments

Hi @alimuldal,

Thank you for the package. I came across the repo and given the no-maintenance intended note updated it. Would you be willing to accept the PR with the idea that I'll take over maintenance? If not, I'll create a stand-alone repo from the fork but it might be nice to keep the name.

The PR contains the following changes and enhancements:

Changes

  • Revert to original 1 base indexing for dip.c as I encountered buffer overruns with the 0 based indexing
  • Switch to C++ bindings using Pybind11

Enhancements

  • Moved p-value computation using bootstrapping to C++
  • Added optional parallelisation (OpenMP) for p-value computation
  • Move debug checks under compile-time definition
  • CICD pipeline to create wheels across Windows, Linux and MacOS
  • Valgrind and Asan tests in the pipelines

fixes #5, fixes #7 fixes #10, fixes #11, fixes #12

RUrlus avatar Mar 21 '22 10:03 RUrlus

Hi @alimuldal, would you be willing to hand-over maintenance of the repo or perhaps archive it such that we can promote the fork and keep the name?

RUrlus avatar Jun 27 '22 09:06 RUrlus