langs-in-rust icon indicating copy to clipboard operation
langs-in-rust copied to clipboard

Published 20 hours ago • verified publisher icon alilleybrinker

Added SkyLang

Open gorentbarak opened this issue 2 years ago • 9 comments

gorentbarak avatar Nov 30 '23 19:11 gorentbarak

It looks like this change adds the language to the README, but not to the JSON file which is used to build the README. Can you resubmit with the appropriate new entry in the JSON file, and then re-run the build script to rebuild the README?

alilleybrinker avatar Dec 03 '23 18:12 alilleybrinker

Oh, I didn't realize :p.

gorentbarak avatar Dec 03 '23 18:12 gorentbarak

@alilleybrinker I added Skylang to the JSON file and re-ran the script :).

gorentbarak avatar Dec 03 '23 20:12 gorentbarak

This nukes a bunch of things that got added to the README but not the JSON data. I fixed those missing entries in my PR #100, I suggest that get merged first, then this get rebased on that with just the JSON update while re-running the readme generator to only add the new correct data without clobbering other entries.

alerque avatar Dec 05 '23 20:12 alerque

@alerque oh, good idea. well, nice that you made a PR.

gorentbarak avatar Dec 05 '23 21:12 gorentbarak

dont know why things got added to the readme and not json :/

gorentbarak avatar Dec 05 '23 21:12 gorentbarak

My PR is merged that handles all the missing JSON data. You can rebase this PR now, but probably what you want to do is just cherry pick the second commit and only the changes to the JSON file, then re-run the readme updater. That should get around all the conflicts that are going to come up. If you like I can easily do that and submit a replacement PR.

alerque avatar Dec 06 '23 06:12 alerque

Two things:

  1. There's now a conflict with the README. Can you re-apply your changes on top of main?
  2. It looks like you've committed a tags file, which should be removed from the PR

Once that's resolved this will be ready to merge!

alilleybrinker avatar Dec 07 '23 17:12 alilleybrinker

I tried to cherry-pick just the change to the JSON data, but it turns out this project doesn't have a mirror on GitHub, and the tooling for this repo currently clobbers and deletes anything that doesn't lookup right via the GitHub API.

Obviously this isn't the fault of SkyLang for using a different forge, but this PR should probably be stripped to just the JSON entry and then held open (perhaps in Draft mode) until this project's tooling is fixed to accept other forges.

alerque avatar Dec 08 '23 18:12 alerque

Going to close this one, as it's been in an un-mergeable state for some time. If you want to submit a fresh one that's mergeable I'd happily accept it.

alilleybrinker avatar Apr 16 '25 21:04 alilleybrinker