alifeee
alifeee
sounds good. we should make a PR from https://github.com/burnash/gspread/compare/master..fix/api_key-auth-version not sure if it's that testable, will need a bit of manual testing, as version numbers are being screwed around with...
Hi :) This seems good. It seems like something difficult to test(?) The issue #1169 asked for: > It would be interesting if there was a single exception that handled...
okay. It seems a simple enough change 👍. Not sure if it fixes #1169 though as they asked for an Exception to be thrown(?)
> @alifeee you're ok to merge this as is ? knowing that it's not solving #1169 . but so far it provides the info to the user. sure, I am...
ok, so the user would be expected to do something like... ```python if client.expiry > datetime.today(): # throw error! cannot do things properly! # no error, continue worksheet.update_acell("A1", "hi") ```...
ok. seems a good change 👌 can merge
If there were bugs before, and this fixes the bugs. We should have a test that proves it. :)
> You're right I'll add a test. I'll add a call to the method define_named_range with both a1 and index based coordinates. I am confused about the test. You added...
> or add it back to the HTTPClient so users can do: spreadsheet.client.import_csv() but we put back the deprecation warnings, in order to be very clean. and we live with...
something must be changed to fix #1423, no?