avatarify-python
avatarify-python copied to clipboard
alievk
Port conflict in client docker setup
https://github.com/alievk/avatarify/blob/e3302b94059f0dfb6b32b82ff2c1e3ca3834cbb3/run.sh#L112
Using 5557 twice
Do you mean you get a conflict when running client and server on the same machine? In that case you should add the --is-local-client flag (as stated in the wiki).
No, I mean that the script tries to use the same port 5557 twice : -p 5557:5554 -p 5557:5558
The first one can be safely deleted as it is not used anywhere. Not sure if the second one is right though. I will look into this as soon as I find the time.
Both can be deleted as the ports are already exposed in the Dockerfile. @alievk If you like you can just remove the whole if statement in the run.sh there. Otherwise I can make a pr. Also in #296 a mistake in the readme was reported (you would just need to replace a 'hardly' with 'highly'). Might be easier for you to do both things directly than with a pr.
Edit: only the corresponding elif not the if there itself. So from 109 it should be:
if [[ $DOCKER_IS_LOCAL_CLIENT == 1 ]]; then
DOCKER_ARGS="$DOCKER_ARGS --network=host"
fi