SublimeAllAutocomplete icon indicating copy to clipboard operation
SublimeAllAutocomplete copied to clipboard

Update all_views_completions.py

Open hypnopump opened this issue 4 years ago • 3 comments

saves a list declaration and posterior slice. a bit uglier

hypnopump avatar Jul 19 '21 12:07 hypnopump

Hi @hypnopump, thanks for your contribution!

Does this change improve performance in a meaningful way?

alienhard avatar Jul 22 '21 13:07 alienhard

hm not that i was aware of. It was pretty much the same. The thing i saw that could help significantly is in the final construction of suggestion, which uses a set and a list. One could speed that up by using only a set, but unfortunately it wouldn't conserve the order (alphabetical order would be favoured instead)

hypnopump avatar Jul 22 '21 17:07 hypnopump

ok, maybe I had misunderstood the motivation for your PR... It saves a few statements but in turn makes the code harder to read IMHO. Unless there's an actual performance gain, which appears not to be the case, I'd rather not apply the change.

alienhard avatar Jul 22 '21 23:07 alienhard