Sentinel icon indicating copy to clipboard operation
Sentinel copied to clipboard

UI Updates, split commits.

Open romanr opened this issue 8 months ago • 4 comments

This is much clearer PR, with changes grouped by commits. Updated UI according to design, and adde canvas previews.

romanr avatar May 02 '25 05:05 romanr

What I've been referring to is having one commit per PR. For example, I still don't want to alter my repo project settings and add canvas previews for my personal repo, so I can't merge this whole PR because it has 6 commits in it. I can't pick and choose which commits to approve, it's all or nothing. Let's leave this one open and I'll just cherry pick the changes and add them locally on my end to see how it looks. I'll update you once I get a chance to do it.

alienator88 avatar May 02 '25 22:05 alienator88

What do you mean commit to your private repo? This is an open source project.
I don't know what's tour experience with open source but nobody is keeping some versions of projects that are different from the main repo.

The issue with code signing is just that - an issue, it's not the reason for collaborators to keep different uncommitted project files, or waste time on branch switching and maintaining separate project files.

The canvas previews, if you mean you don't want to use them then you don't have to turn that on. If canvas is not activated it does not execute any code.

And if you had any issues with canvas in the past as some people did, it's likely been fixed, I didn't have any problems with it in long time.

romanr avatar May 03 '25 02:05 romanr

I mean, I've had multiple PRs across all of my open source apps..just never had someone try and commit changes to the xcode project settings before, like the schema stuff is what I'm getting at.

I don't know if there's some miscommunication happening or what. But like I said, I'll manually test some of these changes and go from there. Thank you for the contributions.

Speaking of contributions, I want to add your username or name in the About window if you want. How would you like it displayed?

alienator88 avatar May 03 '25 04:05 alienator88

the new icon is pushed here 🎆

romanr avatar May 12 '25 14:05 romanr