Meshroom icon indicating copy to clipboard operation
Meshroom copied to clipboard

[ui] Elapsed time indicators in log

Open mugulmd opened this issue 1 year ago • 5 comments

Description

The goal of this PR is to enrich the node log viewer so that finding the steps that require long calculations is easier for users. To achieve that, we retrieve the time value of each log-line (when it exists) and we display the elapsed time between consecutive time values.

We add 2 visual indicators:

  • a colored marker next to the line number
  • a tooltip when hovering over the line number cell displaying the elapsed time.

mugulmd avatar Sep 30 '22 10:09 mugulmd

For now there are still 2 main issues to work on that I noted:

  • the color scale for the markers is arbitrary and definitely requires some fine-tuning
  • when changing the chunk while displaying the log, the following QML warning appear: TextFileViewer.qml:274: TypeError: Value is undefined and could not be converted to an object

mugulmd avatar Sep 30 '22 10:09 mugulmd

The colorbar should have the line height: image

fabiencastan avatar Sep 30 '22 21:09 fabiencastan

Time in tooltip should be formatted h:m:s. The zone to display the Tooltip should include the colorbar.

fabiencastan avatar Sep 30 '22 21:09 fabiencastan

Should interpolate colors.

fabiencastan avatar Sep 30 '22 21:09 fabiencastan

The colorbar should be grey if the timing is 0 (and not the same than the background), so we can always see a continuous vertical line.

fabiencastan avatar Sep 30 '22 21:09 fabiencastan