Meshroom icon indicating copy to clipboard operation
Meshroom copied to clipboard

Distortion Parameter details

Open natowi opened this issue 2 years ago • 3 comments

Description

Clarifying Distortion Parameter order

Related to https://github.com/alicevision/meshroom/issues/1647 https://github.com/alicevision/meshroom/issues/1484

natowi avatar Mar 19 '22 10:03 natowi

@servantftechnicolor In that case it would be great if you could provide more details

I found this - does the order apply for this node as well?:

1: Pinhole => 3 parameters (focal, principal point x, principal point y) 2: Pinhole radial 1 => 4 params (focal, principal point x, principal point y, one radial distortion factor) 3: Pinhole radial 3 (default) => 6 params (focal, principal point x, principal point y, 3 radial distortion factors) 4: Pinhole brown 2 => 8 params (focal, principal point x, principal point y, 5 distortion factors (3radial+2 tangential)) 5: Pinhole with a simple Fish-eye distortion => 7 params (focal, principal point x, principal point y, 4 distortion factors) https://github.com/openMVG/openMVG/issues/678#issuecomment-260844969 https://openmvg.readthedocs.io/en/latest/openMVG/cameras/cameras/#pinhole-camera-model

natowi avatar Mar 25 '22 14:03 natowi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 05:07 stale[bot]

we need to put this info somewhere. I had started to compile something like this image I need to complete it with the 3DE models but then we should put it in the Doxygen of each class and in the main doc

simogasp avatar Jul 31 '22 09:07 simogasp

The 3de parameters can be taken fom here: https://github.com/alicevision/AliceVision/blob/develop/src/aliceVision/camera/Pinhole3DE.hpp https://github.com/alicevision/AliceVision/blob/develop/src/aliceVision/camera/Distortion3DE.hpp

I found documentation for the 3de models: https://www.3dequalizer.com/user_daten/tech_docs/pdf/ldpk.pdf https://www.3dequalizer.com/user_daten/tech_docs/pdf/distortion.pdf

This is also a good reference: https://github.com/NatronGitHub/openfx-misc/tree/master/Distortion

natowi avatar Jan 19 '23 21:01 natowi