AliceVision icon indicating copy to clipboard operation
AliceVision copied to clipboard

Create VCPKG port

Open fabiencastan opened this issue 4 years ago • 15 comments

Someone started a PR in this direction: https://github.com/microsoft/vcpkg/pull/8829

It would be good to finalize it, without hacking/patching the CMakeList.txt but doing the fixes needed directly in the repo.

fabiencastan avatar Apr 14 '20 22:04 fabiencastan

@ChaoJia @JackBoosY Would you be interested in helping us on that?

Currently the build of all the dependencies works fine on windows. The build of the dependencies works almost fine on linux with the exception of alembic which is still a windows-only port file.

We also need to create the port files for https://github.com/alicevision/popsift, https://github.com/alicevision/CCTag and https://github.com/laurentkneip/opengv.

fabiencastan avatar Apr 19 '20 10:04 fabiencastan

PopSift PR: https://github.com/microsoft/vcpkg/pull/10979

fabiencastan avatar Apr 19 '20 19:04 fabiencastan

Alembic PR: https://github.com/microsoft/vcpkg/pull/10912

Regarding alembic there is a build error, due to -Werror in debug: https://github.com/alembic/alembic/issues/263 So there is a workaround in the vcpkg portfile.

fabiencastan avatar Apr 19 '20 19:04 fabiencastan

We very much look forward to you can propose more PRs to add more ports in vcpkg!

JackBoosY avatar Apr 23 '20 06:04 JackBoosY

CCTag PR: https://github.com/microsoft/vcpkg/pull/16719

fabiencastan avatar Apr 20 '21 07:04 fabiencastan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 16 '22 00:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 12 '23 00:04 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 07 '24 00:04 github-actions[bot]

Will continue to add this to vcpkg.

JackBoosY avatar Apr 08 '24 06:04 JackBoosY

One question, I found the temporary code here: https://github.com/alicevision/AliceVision/blob/6348b0f346bd8b1efbd1c28e10ebf4dded5df5e0/src/CMakeLists.txt#L301-L308

Why disable dynamic boost here?

I disabled the code block and built successfully.

JackBoosY avatar Apr 08 '24 13:04 JackBoosY

Another question: We have cmake option ALICEVISION_USE_MESHSDFILTER here: https://github.com/alicevision/AliceVision/blob/6348b0f346bd8b1efbd1c28e10ebf4dded5df5e0/src/CMakeLists.txt#L77

However, the configure system checks whether meshsdfilter folder is exists: https://github.com/alicevision/AliceVision/blob/6348b0f346bd8b1efbd1c28e10ebf4dded5df5e0/src/CMakeLists.txt#L181-L185

I think the code block should requires ALICEVISION_USE_MESHSDFILTER is ON.

JackBoosY avatar Apr 08 '24 13:04 JackBoosY

I think the code block should requires ALICEVISION_USE_MESHSDFILTER is ON.

Yes, you are right, that piece of code should be surrounded by an IF (ALICEVISION_USE_MESHSDFILTER)

simogasp avatar Apr 08 '24 14:04 simogasp

@simogasp Can you explain why the first question happens?

JackBoosY avatar Apr 10 '24 02:04 JackBoosY

@simogasp Can you explain why the first question happens?

Sorry, I have no idea, does disabling auto-linking via BOOST_ALL_NO_LIB mean that dynamic linking is also disabled?

simogasp avatar Apr 10 '24 06:04 simogasp

Can anyone review my PR https://github.com/microsoft/vcpkg/pull/38034?

JackBoosY avatar Apr 28 '24 15:04 JackBoosY