AliceVision icon indicating copy to clipboard operation
AliceVision copied to clipboard

Add "Generic" Feature Type

Open mh0g opened this issue 1 year ago • 8 comments

Description

Added a 'generic' feature type for importing features that are not computed by alicevision.

For now the descriptor size is set to 128, but may be extended and padded with 0 to support wider descriptors in the future.

mh0g avatar Nov 16 '23 11:11 mh0g

Why not call it "Custom Feature Type"?

natowi avatar May 21 '24 15:05 natowi

@mh0g Could you rebase, to avoid merge nodes in the PR?

fabiencastan avatar May 25 '24 09:05 fabiencastan

Or "Generic128" ?

fabiencastan avatar May 25 '24 09:05 fabiencastan

Can I ask why you chose to limit it to 128?

MrClock8163 avatar May 25 '24 13:05 MrClock8163

How would you do to get something fully dynamic?

fabiencastan avatar May 25 '24 13:05 fabiencastan

I meant the question as in, why limit it to such a low number to begin with? I understand that there has to be a limit, but why 128? Granted, 128 is probably more than enough for control points, but if someone would want to import en-masse matches, that would be impossible this way.

MrClock8163 avatar May 25 '24 16:05 MrClock8163

128 is for the memory size of each descriptor, not for the number of features/matches.

fabiencastan avatar May 25 '24 20:05 fabiencastan

I see. I suppose I misunderstood then. Figured this would work the same way as the CCTAG and AprilTag marker describers, where each match is a 128 bytes block, and FF byte in the block identifies the marker ID, which limits it to 128 different markers. Sorry for the confusion.

MrClock8163 avatar May 25 '24 21:05 MrClock8163