AliceVision icon indicating copy to clipboard operation
AliceVision copied to clipboard

Published 20 hours ago • verified publisher icon alicevision

[keyframeselection] Algorithms are rewritten

Open servantftechnicolor opened this issue 1 year ago • 3 comments

Keyframe selection was not working previously.

This PR tries a new set of algorithms to replace the previous one

  • A simple one which simply perform a regular sampling on the temporal dimension
  • A more complex one which take the frame with the sharper value in a window, and check that this frame has sufficient motion with the previous selection frame.

servantftechnicolor avatar Sep 05 '22 09:09 servantftechnicolor

#include <opencv2/optflow.h> is not found in the linux CI. Should we add a module here? https://github.com/alicevision/AliceVision/blob/develop/CMakeLists.txt#L687

fabiencastan avatar Sep 05 '22 18:09 fabiencastan

Do we really need highgui here? keyframe/KeyframeSelector.cpp:20:31: fatal error: opencv2/highgui.hpp: No such file or directory

fabiencastan avatar Sep 16 '22 22:09 fabiencastan

  • simple mode tested and works

mh0g avatar Sep 30 '22 07:09 mh0g

Tested simple and advanced mode on windows, seems to work as intended. Note: cmake option ALICEVISION_USE_OPENCV is off by default, to be working off the shelf, cmake needs to be called with -DALICEVISION_USE_OPENCV=ON

mh0g avatar Oct 25 '22 11:10 mh0g