AliceVision icon indicating copy to clipboard operation
AliceVision copied to clipboard

Published 20 hours ago • verified publisher icon alicevision

Avoid unnecessary string copies

Open p12tic opened this issue 3 years ago • 2 comments

This is a simple cleanup PR that removes accidental copies of strings where needed. The performance impact is trivial, but it's still worth to consistently use pass-by-reference lest some function does end up in a critical path.

p12tic avatar Jul 17 '22 11:07 p12tic

I added more cleanups which I didn't notice the first time.

p12tic avatar Jul 22 '22 21:07 p12tic

Thanks for the PR! We have a large PR on depth maps here: https://github.com/alicevision/AliceVision/pull/1163 I would like to merge it first, to avoid new merge conflicts.

fabiencastan avatar Jul 25 '22 17:07 fabiencastan

Looking at it again, there should not be too much conflicts.

fabiencastan avatar Sep 27 '22 20:09 fabiencastan