asprom icon indicating copy to clipboard operation
asprom copied to clipboard

Added TLS support configuration

Open Liron24 opened this issue 6 years ago • 7 comments

Hi alicebob, I have added a TLS support to the tool. I changed the flags a bit and basically added an option to choose either secure connection or not. Would love to contribute back, wdyt?

Liron24 avatar Nov 07 '18 13:11 Liron24

Sounds good! Could you open a PR, @Liron24 ?

alicebob avatar Nov 08 '18 02:11 alicebob

Hi, seems that I don't have permissions to create new branch, can you grant me? Or do you prefer do it some other way?

Liron24 avatar Nov 29 '18 23:11 Liron24

Hi @Liron24. You would make a fork of this repository (there is a button above somewhere). That gives you a copy in github.com/Liron24/asprom, which you can use to make your changes. When that's done you open a Pull Request in there, and it should show up here. Let me know if I can help you with anything. There is also https://help.github.com/articles/fork-a-repo/ which might give you more details.

alicebob avatar Nov 30 '18 01:11 alicebob

Done :) Thank you.

Liron24 avatar Nov 30 '18 02:11 Liron24

Hi @Liron24 and @alicebob Which version does it support tls

Asisranjan avatar Dec 08 '19 13:12 Asisranjan

@Asisranjan I didn't see it get merged in. @Alb0t are you running the TLS fork?

MicahCarrick avatar Dec 11 '19 03:12 MicahCarrick

Negative @MicahCarrick

Alb0t avatar Dec 11 '19 03:12 Alb0t