userChrome.js icon indicating copy to clipboard operation
userChrome.js copied to clipboard

Error with UndoListInTabmenuToo.uc.js

Open Speravir opened this issue 11 months ago • 0 comments

Hello, this script produces an error message in browser console (or actually two, but related):

00:51:38.821 Uncaught TypeError: undoPopup.childNodes[(i + 2)] is undefined
    populateUndoSubmenu $path$/UndoListInTabmenuToo_edit.uc.js:145
    makePopup $path$/UndoListInTabmenuToo_edit.uc.js:100
UndoListInTabmenuToo_edit.uc.js:145:7

(I replaced the long file path with $path$.)

This refers to the latest version.

Quite probably related to this, on Camp-Firefox.de this has been noticed (in a long thread with meanwhile more than 20 pages):

  • The code in line 151 should create a menuitem for clearing the closed tab list, but this does not happen.
  • The tooltips are shifted. For me its off by one: The first entry has no tooltip, the second one gets the tooltip which belongs to the first entry and so on. For the user who noticed both issues its off by two, confer posted image in posting from 15 Januar 2025, 11:37.

Additionally: If there are no closed tabs and windows it would be preferrable to grey out the menu text.

And isn’t the word historis inside the comment in line 135 a spelling mistake?

In additon: There is also a request, whether the submenu could be made wider. The user wishes the script should get a similar width as with the addon Undo Close Tab and provided an image for comparison (top addon, bottom script), see posting from 19 Januar 2025, 13:25.

Speravir avatar Jan 18 '25 00:01 Speravir