vlayout icon indicating copy to clipboard operation
vlayout copied to clipboard
verified publisher icon alibaba

Clean up printing stack trace call when exception occurred

Open hexise opened this issue 6 years ago • 0 comments

Exception should be logged by calling: Log.e(String, String, Throwable) or some others Log's method.

In the vlayout code, there are lots of e.printStackTrace(). Those calls should be replaced by the appropriate Log.x methods.

In my app log when using vlayout, I received countless stack trace which are mostly useless. For instance, following one:

04-25 17:08:48.231 18785 18785 W System.err: java.lang.NoSuchMethodException: ng.hide [class android.view.View]
04-25 17:08:48.233 18785 18785 W System.err: 	at java.lang.Class.getMethod(Class.java:2068)
04-25 17:08:48.233 18785 18785 W System.err: 	at java.lang.Class.getDeclaredMethod(Class.java:2047)
04-25 17:08:48.233 18785 18785 W System.err: 	at ox$b.a(ExposeLinearLayoutManagerEx.java:1899)
04-25 17:08:48.233 18785 18785 W System.err: 	at ox$b.b(ExposeLinearLayoutManagerEx.java:1953)
04-25 17:08:48.233 18785 18785 W System.err: 	at ox.p(ExposeLinearLayoutManagerEx.java:1462)
04-25 17:08:48.233 18785 18785 W System.err: 	at com.alibaba.android.vlayout.VirtualLayoutManager.p(VirtualLayoutManager.java:1174)
04-25 17:08:48.233 18785 18785 W System.err: 	at com.alibaba.android.vlayout.VirtualLayoutManager.a(VirtualLayoutManager.java:1133)
04-25 17:08:48.233 18785 18785 W System.err: 	at com.alibaba.android.vlayout.VirtualLayoutManager.a(VirtualLayoutManager.java:1127)
04-25 17:08:48.233 18785 18785 W System.err: 	at pr.b(SingleLayoutHelper.java:86)
04-25 17:08:48.233 18785 18785 W System.err: 	at pi.a(BaseLayoutHelper.java:318)
04-25 17:08:48.233 18785 18785 W System.err: 	at com.alibaba.android.vlayout.VirtualLayoutManager.a(VirtualLayoutManager.java:639)
04-25 17:08:48.233 18785 18785 W System.err: 	at ox.a(ExposeLinearLayoutManagerEx.java:1162)
04-25 17:08:48.233 18785 18785 W System.err: 	at ox.c(ExposeLinearLayoutManagerEx.java:365)
04-25 17:08:48.233 18785 18785 W System.err: 	at com.alibaba.android.vlayout.VirtualLayoutManager.c(VirtualLayoutManager.java:463)
04-25 17:08:48.233 18785 18785 W System.err: 	at android.support.v7.widget.RecyclerView.N(RecyclerView.java:3812)
04-25 17:08:48.233 18785 18785 W System.err: 	at android.support.v7.widget.RecyclerView.q(RecyclerView.java:3529)
04-25 17:08:48.233 18785 18785 W System.err: 	at android.support.v7.widget.RecyclerView.onLayout(RecyclerView.java:4082)
04-25 17:08:48.233 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.233 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1083)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.support.v4.widget.SlidingUpPanelLayout.onLayout(SlidingUpPanelLayout.java:851)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1791)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1635)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.LinearLayout.onLayout(LinearLayout.java:1544)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.support.v4.widget.DrawerLayout.onLayout(DrawerLayout.java:1171)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1791)
04-25 17:08:48.234 18785 18785 W System.err: 	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1635)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.widget.LinearLayout.onLayout(LinearLayout.java:1544)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
04-25 17:08:48.235 18785 18785 W System.err: 	at com.android.internal.policy.DecorView.onLayout(DecorView.java:955)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.View.layout(View.java:20964)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.ViewGroup.layout(ViewGroup.java:6440)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:3092)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2779)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1863)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8072)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:911)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.Choreographer.doCallbacks(Choreographer.java:723)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.Choreographer.doFrame(Choreographer.java:658)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:897)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.os.Handler.handleCallback(Handler.java:790)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.os.Handler.dispatchMessage(Handler.java:99)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.os.Looper.loop(Looper.java:164)
04-25 17:08:48.235 18785 18785 W System.err: 	at android.app.ActivityThread.main(ActivityThread.java:7000)
04-25 17:08:48.235 18785 18785 W System.err: 	at java.lang.reflect.Method.invoke(Native Method)
04-25 17:08:48.236 18785 18785 W System.err: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:441)
04-25 17:08:48.236 18785 18785 W System.err: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1408)

This is just a failed reflection check, the exception is useless but it is printed everywhere. Please kindly help to refine the code and refactor the exception printStackTrace(), thanks.

hexise avatar Apr 25 '19 15:04 hexise