spring-cloud-alibaba icon indicating copy to clipboard operation
spring-cloud-alibaba copied to clipboard
verified publisher icon alibaba

Is there a problem with the getInstanceResponse method of the NacosLoadBalancer class?

Open laizixiang0720 opened this issue 1 year ago • 6 comments

Which Component spring-cloud-starter-alibaba-nacos-discovery:2022.0.0.0 Describe what problem you have encountered When I use nacos to make cross-cluster calls, I find that there is no warning like in previous versions. I feel that there is a problem with the following code. image

laizixiang0720 avatar Dec 31 '23 15:12 laizixiang0720

Yes, I think it would be better to move the log to the point you suggested. Would you like to submit a pull request?

chickenlj avatar Jan 04 '24 08:01 chickenlj

Hi, this task looks very simple. Can I do it? I happen to want to complete a PR process for the first time

Suzzt avatar Jan 04 '24 09:01 Suzzt

Hi, this task looks very simple. Can I do it? I happen to want to complete a PR process for the first time

You can submit PR directly to complete it. 👍

yuluo-yx avatar Jan 04 '24 11:01 yuluo-yx

@chickenlj @laizixiang0720 @yuluo-yx I have reviewed my code myself I was wondering if we made a mistake? We shouldn't just put it at the end here. There should be a judgment here that there is no 'sameClusterinstances', and only with a warning prompt can it be reasonable

BWT, is there any ambiguity in the prompt text here? Would it be better to change it to "No specified cluster service node found"? Or do you have any better ideas?

image

Suzzt avatar Jan 05 '24 10:01 Suzzt

Good job, you can submit your idea to PR along with your code implementation and we'll review your changes there. @Suzzt cc @chickenlj

yuluo-yx avatar Jan 05 '24 11:01 yuluo-yx

👌,Let's go to CR together to discuss.

Suzzt avatar Jan 05 '24 12:01 Suzzt