sentinel-golang icon indicating copy to clipboard operation
sentinel-golang copied to clipboard

[feature] integrate datasource of OpenSergo by OpenSergo Go SDK

Open jnan806 opened this issue 2 years ago • 4 comments

Does this pull request fix one issue?

fixed #483

Special notes for reviews

~~### Prepare Environment for Test Version~~

~~- Prepare the OpenSergo GO SDK. Because of the OpenSergo GO SDK has no published version, so should download the sourcecode of OpenSergo GO SDKjnan806/opensergo-go-sdk/tree/initial-version, and move it into you GOPATH.~~ ~~- Rename the right version in directory name of OpenSergo GO SDK sourcecode. Make sure the version in sourcecode directory name is the same with go.mod.
eg. $GOPATH/pkg/mod/github.com/opensergo/[email protected]~~

The jnan806/opensergo-go-sdk/tree/initial-version has been merged into opensergo/opensergo-go-sdk. So this step of Prepare the OpenSergo GO SDK` is unnecessary. It's only need to add use sentinel-go with the opensergo-datasource.

Samples

jnan806 avatar Oct 14 '22 01:10 jnan806

@binbin0325 @louyuting @luckyxiaoqiang Any further suggestions?

sczyh30 avatar Dec 03 '22 03:12 sczyh30

We might need to discuss the model of the OpenSergo data-source soon (to make it clear).

sczyh30 avatar Dec 26 '22 09:12 sczyh30

cc @binbin0325 for update

sczyh30 avatar Jan 09 '23 09:01 sczyh30

@sczyh30

Cloud you help me to check and complete the // TODO list in file fix#483-datasource-opensergo -> opensergo_sentinel_assembler.go to fill filed-mapping between pb-message and sentinel rule. And then delete the // TODO comment line.

You can commit into the branch jnan806/sentinel-golang/fix#483-datasource-opensergo directly.

jnan806 avatar Jan 11 '23 01:01 jnan806