sentinel-golang icon indicating copy to clipboard operation
sentinel-golang copied to clipboard

Published 20 hours ago • verified publisher icon alibaba

Fix app name in metric is unknown_go_service (#453)

Open kklinan opened this issue 2 years ago • 6 comments

Describe what this PR does / why we need it

Does this pull request fix one issue?

Fixes #453

Describe how you did it

Describe how to verify it

Special notes for reviews

kklinan avatar Jan 26 '22 09:01 kklinan

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 26 '22 09:01 CLAassistant

Could you please fix the CI failure?

sczyh30 avatar Feb 08 '22 05:02 sczyh30

CI 处理一下吧，有data race

删除 once 导致的，是否不应该删除呢？

kklinan avatar May 18 '22 04:05 kklinan

CI 处理一下吧，有data race

删除 once 导致的，是否不应该删除呢？

嗯嗯，目前看还是使用once吧

binbin0325 avatar May 18 '22 04:05 binbin0325

这个提交是否还有问题呢，然后什么时候能合并嘞，目前在最新的 [v1.0.4] tag 下还是有这个问题的 @kklinan @binbin0325 @sczyh30

eiopus avatar Dec 08 '22 09:12 eiopus

加油，需要这个修复

qshuai avatar Jan 06 '23 06:01 qshuai