nacos icon indicating copy to clipboard operation
nacos copied to clipboard

[ISSUE#8936]rpc client add system properties class

Open stone-98 opened this issue 2 years ago • 1 comments

What is the purpose of the change

close #8936

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [ ] Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

stone-98 avatar Aug 10 '22 15:08 stone-98

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 10 '22 15:08 CLAassistant

There is some code that has not yet been committed and will be committed later

stone-98 avatar Aug 11 '22 02:08 stone-98

请现在相关issue中讨论清楚方案。pr中的方案我认为不是很合适

好的,我再去了解一下相关功能。

stone-98 avatar Aug 11 '22 06:08 stone-98