nacos
nacos copied to clipboard
[ISSUE #8925] fix that the replaceAll operation is invalid
Close #8928
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
- [x] Run
mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.
Codecov Report
Merging #8929 (3645c73) into develop (3586ad6) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #8929 +/- ##
=============================================
+ Coverage 43.30% 43.32% +0.01%
Complexity 4720 4720
=============================================
Files 912 912
Lines 32584 32583 -1
Branches 3761 3760 -1
=============================================
+ Hits 14112 14118 +6
+ Misses 17114 17105 -9
- Partials 1358 1360 +2
Impacted Files | Coverage Δ | |
---|---|---|
...ba/nacos/client/config/impl/ServerListManager.java | 64.68% <100.00%> (-0.14%) |
:arrow_down: |
...os/client/auth/ram/identify/CredentialService.java | 78.84% <0.00%> (-3.85%) |
:arrow_down: |
.../nacos/naming/healthcheck/ClientBeatCheckTask.java | 30.30% <0.00%> (-1.52%) |
:arrow_down: |
...a/com/alibaba/nacos/naming/push/v1/PushClient.java | 46.93% <0.00%> (ø) |
|
.../naming/push/v1/NamingSubscriberServiceV1Impl.java | 82.53% <0.00%> (+15.87%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3586ad6...3645c73. Read the comment docs.
Het