nacos
nacos copied to clipboard
Feat/bug fix config history rollback missing type
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
for #8799 ,添加type字段到历史记录表中,显示配置原始类型
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
- [ ] Run
mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.
Codecov Report
Merging #8800 (1075b13) into develop (e97b695) will decrease coverage by
0.05%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #8800 +/- ##
=============================================
- Coverage 43.28% 43.23% -0.06%
Complexity 4707 4707
=============================================
Files 904 904
Lines 32494 32494
Branches 3748 3748
=============================================
- Hits 14066 14048 -18
- Misses 17078 17094 +16
- Partials 1350 1352 +2
Impacted Files | Coverage Δ | |
---|---|---|
...alibaba/nacos/client/config/impl/ClientWorker.java | 50.29% <0.00%> (-4.68%) |
:arrow_down: |
.../alibaba/nacos/client/naming/beat/BeatReactor.java | 52.87% <0.00%> (-3.45%) |
:arrow_down: |
...nacos/naming/healthcheck/v2/HealthCheckTaskV2.java | 75.00% <0.00%> (-1.32%) |
:arrow_down: |
...os/common/trace/publisher/TraceEventPublisher.java | 72.83% <0.00%> (-1.24%) |
:arrow_down: |
...m/alibaba/nacos/core/remote/ConnectionManager.java | 39.05% <0.00%> (+1.18%) |
:arrow_up: |
.../nacos/naming/healthcheck/ClientBeatCheckTask.java | 31.81% <0.00%> (+1.51%) |
:arrow_up: |
...m/alibaba/nacos/naming/misc/HttpClientManager.java | 83.33% <0.00%> (+14.28%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e97b695...1075b13. Read the comment docs.
Thanks for your feedback and contribution. But the issue/pull request has not had recent activity more than 180 days. This issue/pull request will be closed if no further activity occurs 7 days later. We may solve this issue in new version. So can you upgrade to newest version and retry? If there are still issues or want to contribute again. Please create new issue or pull request again.
不兼容的改动,需要升级表结构,不建议当前版本合入,可以下一次大版本中再考虑