nacos icon indicating copy to clipboard operation
nacos copied to clipboard

Discussion about optimization items in gray and beta configuration

Open lingyufei opened this issue 5 months ago • 5 comments

In PR 13587, I discussed with @KomachiSion about optimization items in gray and beta configurations. I'm creating this issue for discussion and tracking.

  1. These 2 beta related issues 13585 13580 in Nacos V3. Do we need to do some related enhancements in V2?

I checked the code in v2.x-develop, the beta config deletion functionality works fine. The deletion is handled by deleteConfigGrayV1 properly in V2. ConfigController#stopBeta -> ConfigOperationService#deleteConfig -> ConfigGrayModelMigrateService.deleteConfigGrayV1

image image
  1. In Nacos v3, we can make the code more graceful. It seems that the beta table deletion can be handled by deleteConfigGrayV1 properly. Not sure why we remove it from ConfigControllerV3. Maybe we can use deleteConfigGrayV1(dataId, group, namespaceId, BetaGrayRule.TYPE_BETA, null, null) in ConfigControllerV3.
image

lingyufei avatar Jul 04 '25 10:07 lingyufei

@shiyiyue1102 Do you have any insight into this? Should we do any enhancements in V2 and V3?

lingyufei avatar Jul 04 '25 10:07 lingyufei

Grayscale compatibility mode is expected to be removed in several future versions, and can be optimized to facilitate future removal

shiyiyue1102 avatar Jul 10 '25 02:07 shiyiyue1102

Grayscale compatibility mode is expected to be removed in several future versions, and can be optimized to facilitate future removal

Is there anything I can do for Grayscale compatibility mode? Would you like me to optimize the item I mentioned above👆?

lingyufei avatar Jul 28 '25 13:07 lingyufei

Grayscale

in future, all config operation logic should be uniformed to ConfigOperationService ,include ConfigControllerV3,If you are willing to help optimize it ,that would be great.

shiyiyue1102 avatar Oct 09 '25 03:10 shiyiyue1102

This issue has been open 30 days with no activity. This will be closed in 7 days.

github-actions[bot] avatar Nov 30 '25 02:11 github-actions[bot]