nacos icon indicating copy to clipboard operation
nacos copied to clipboard

[ISSUE #12282]Fix the issue where monitoring data cannot be found thr…

Open HMYDK opened this issue 1 year ago • 0 comments

What is the purpose of the change

#12282 Fix the issue where monitoring data cannot be found through the IP dimension in the ListeningQuery

Brief changelog

Add new query methods in the CommunicationController to support both IP and config queries. Additionally, mark @GetMapping("/configWatchers") and @GetMapping("/watcherConfigs") as @Deprecated.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • [ ] Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

HMYDK avatar Jun 26 '24 16:06 HMYDK