metrics icon indicating copy to clipboard operation
metrics copied to clipboard

FileMetricManagerReporter#timestampPrecision单位转换BUG

Open vision57 opened this issue 5 years ago • 0 comments

https://github.com/dubbo/metrics/blob/49e2ec8d876fc2ce2e1ef99c4cc3ad9add5d60c8/metrics-reporter/src/main/java/com/alibaba/metrics/reporter/file/FileMetricManagerReporter.java#L257

这里单位转换我无法理解,我感觉正确的应该是if (TimeUnit.SECONDS.equals(timestampPrecision)),这样的代码整个库中有好几处,可以全局查找关键字timestampPrecision,不知道是不是BUG呢?

vision57 avatar Apr 15 '19 09:04 vision57