innodb-java-reader icon indicating copy to clipboard operation
innodb-java-reader copied to clipboard

feat: parse the sdi page

Open mikawudi opened this issue 3 years ago • 5 comments

parse the sdi page inner data

issue:https://github.com/alibaba/innodb-java-reader/issues/17

Signed-off-by: xujie [email protected]

mikawudi avatar Dec 22 '20 08:12 mikawudi

Codecov Report

Merging #18 (12a5072) into master (3cb9bdb) will increase coverage by 0.15%. The diff coverage is 84.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
+ Coverage     82.32%   82.48%   +0.15%     
- Complexity     1113     1131      +18     
============================================
  Files            91       93       +2     
  Lines          4148     4236      +88     
  Branches        554      563       +9     
============================================
+ Hits           3415     3494      +79     
- Misses          508      510       +2     
- Partials        225      232       +7     
Impacted Files Coverage Δ Complexity Δ
.../com/alibaba/innodb/java/reader/util/ZlibUtil.java 76.47% <76.47%> (ø) 2.00 <2.00> (?)
...ibaba/innodb/java/reader/page/index/SdiRecord.java 81.39% <81.39%> (ø) 11.00 <11.00> (?)
...a/com/alibaba/innodb/java/reader/page/SdiPage.java 93.33% <92.85%> (-6.67%) 4.00 <4.00> (+3.00) :arrow_down:
...aba/innodb/java/reader/page/index/IndexHeader.java 96.66% <0.00%> (ø) 15.00% <0.00%> (ø%)
...om/alibaba/innodb/java/reader/util/SliceInput.java 72.52% <0.00%> (+5.49%) 29.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cb9bdb...12a5072. Read the comment docs.

codecov-io avatar Dec 22 '20 09:12 codecov-io

emm~any question in this pr?

mikawudi avatar Jan 07 '21 10:01 mikawudi

@mikawudi the code looks good, it would be better if you are willing to add a test case for sdi page.

neoremind avatar Jan 08 '21 10:01 neoremind

ok~i will add test case later~

mikawudi avatar Jan 12 '21 02:01 mikawudi

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jan 26 '22 02:01 CLAassistant