hooks icon indicating copy to clipboard operation
hooks copied to clipboard

refactor: replace lodash/isEqual with react-fast-compare

Open guoyunhe opened this issue 1 year ago • 4 comments

[中文版模板 / Chinese template]

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / documentation update
  • [ ] Demo update
  • [ ] TypeScript definition update
  • [ ] Bundle size optimization
  • [x] Performance optimization
  • [ ] Enhancement feature
  • [ ] Internationalization
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Test Case
  • [ ] Branch merge
  • [ ] Other (about what?)

🔗 Related issue link

💡 Background and solution

react-fast-compare 提供了与 lodash/isEqual 相同的能力,但是体积更小,性能快了数倍。

image

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • [x] Doc is updated/provided or not needed
  • [x] Demo is updated/provided or not needed
  • [x] TypeScript definition is updated/provided or not needed
  • [x] Changelog is provided or not needed

guoyunhe avatar Jan 30 '24 05:01 guoyunhe

@li-jia-nan @hchlq @miracles1919 @crazylxr 这个有必要替换吗?性能是提高了,但是不清楚会不会有潜在的问题,没用过这个库

liuyib avatar Feb 26 '24 16:02 liuyib

@li-jia-nan @hchlq @miracles1919 @crazylxr 这个有必要替换吗?性能是提高了,但是不清楚会不会有潜在的问题,没用过这个库

我也没用过这个

li-jia-nan avatar Feb 27 '24 01:02 li-jia-nan

v4 再换吧,先 hold 一下

crazylxr avatar Feb 27 '24 01:02 crazylxr

@liuyib antd-mobile 已经换了,目前没有发现问题 https://github.com/ant-design/ant-design-mobile/blob/master/package.json#L33

guoyunhe avatar Feb 27 '24 02:02 guoyunhe

那就整

crazylxr avatar Feb 29 '24 14:02 crazylxr