formily icon indicating copy to clipboard operation
formily copied to clipboard

feat: x-validator支持传入函数 && 解决x-validator 并不能按照预期禁用的问题

Open electroluxcode opened this issue 1 year ago • 0 comments

Before submitting a pull request, please make sure the following is done...

  • [x] Ensure the pull request title and commit message follow the Commit Specific in English.
  • [x] Fork the repo and create your branch from master or formily_next.
  • [x] If you've added code that should be tested, add tests!
  • [x] If you've changed APIs, update the documentation.
  • [] Ensure the test suite passes (npm test).
  • [ ] Make sure your code lints (npm run lint) - we've done our best to make sure these rules match our internal linting guidelines.

Please do not delete the above content

fix https://github.com/alibaba/formily/issues/4214 fix https://github.com/alibaba/formily/issues/4215


What have you changed?

  • 修复 x-validator 中boolean类型不生效的问题
  • x-validator 的object 和 array的 message支持函数形式的传入

electroluxcode avatar Sep 05 '24 15:09 electroluxcode

⚠️ No Changeset found

Latest commit: fc2d65a7648f35b6992ee28e5843c70c30a46e07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 12 '24 18:09 changeset-bot[bot]

Ah, I see what's going on, it's failing a test (as expected), but then its throwing an unrelated error, that put me off, and I wasn't understanding. I think I can continue writing tests..

titoBouzout avatar Sep 12 '24 18:09 titoBouzout

It's a cool Idea. There have been a few design variations on this. Not completely sure which makes the most sense. Mostly wonder if the changes to Stores in 2.0 will have bigger bearing on what the design ultimately is.

ryansolid avatar Sep 12 '24 20:09 ryansolid