f2e-spec icon indicating copy to clipboard operation
f2e-spec copied to clipboard

save unmodified song artist and title to db

Open BWagener opened this issue 9 months ago • 3 comments

What does this PR do?

Save unmodified song artist and title to db instead of collated values.

This is a breaking change to existing databases, as preexisting songs that have been saved with collated artist or title fields will be readded.

We could make it compatible with existing databases by doing both comparisons and just patching existing entries' artist and name fields to be no longer collated.

Closes Issue(s)

#992

How to test these changes

For a thorough description of the bug this PR addresses please refer to #992

Prerequisites:

  • a song, which starts with two consecutive words from this list (or just edit the txt of an existing one to meet the criteria)

Steps to verify:

  • launch the game
  • wait for all songs to load
  • exit the game
  • check the database.xml file
    • only a single entry should exist for the song
    • song artist and name should be the original artist and name
  • repeat the previous steps once

BWagener avatar May 05 '24 08:05 BWagener

@BWagener can you add some test hints to the description, so that testers know what to do.

twollgam avatar May 29 '24 21:05 twollgam