f2e-spec
f2e-spec copied to clipboard
save unmodified song artist and title to db
What does this PR do?
Save unmodified song artist and title to db instead of collated values.
This is a breaking change to existing databases, as preexisting songs that have been saved with collated artist or title fields will be readded.
We could make it compatible with existing databases by doing both comparisons and just patching existing entries' artist and name fields to be no longer collated.
Closes Issue(s)
#992
How to test these changes
For a thorough description of the bug this PR addresses please refer to #992
Prerequisites:
- a song, which starts with two consecutive words from this list (or just edit the txt of an existing one to meet the criteria)
Steps to verify:
- launch the game
- wait for all songs to load
- exit the game
- check the database.xml file
- only a single entry should exist for the song
- song artist and name should be the original artist and name
- repeat the previous steps once
Download the artifacts for this pull request:
- Performous-1.3.1-993-b45eb56-alpha-debian_11.deb.zip
- Performous-1.3.1-993-b45eb56-alpha-ubuntu_22.04.deb.zip
- Performous-1.3.1-993-b45eb56-alpha-fedora_36.rpm.zip
- Performous-1.3.1-993-b45eb56-alpha-fedora_38.rpm.zip
- Performous-1.3.1-993-b45eb56-alpha-ubuntu_24.04.deb.zip
- Performous-1.3.1-993-b45eb56-alpha-fedora_37.rpm.zip
- Performous-1.3.1-993-b45eb56-alpha.AppImage.zip
- Performous-1.3.1-993-b45eb56-alpha-debian_12.deb.zip
- Performous-1.3.1-993-b45eb56-alpha-fedora_35.rpm.zip
- Performous-1.3.1-993-b45eb56-alpha-fedora_40.rpm.zip
- Performous-1.3.1-993-b45eb56-alpha-fedora_39.rpm.zip
- Performous-1.3.1-993-b45eb56-alpha-ubuntu_20.04.deb.zip
- Performous-1.3.1-993-b45eb56-alpha.dmg.zip
- Performous-1.3.1-993-b45eb56-alpha-mingw-w64.exe.zip
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.
@BWagener can you add some test hints to the description, so that testers know what to do.
Quality Gate passed
Issues
3 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code