add new option in song screen menu that exits and mark the song broken

[twollgam]

What does this PR do?

Add new option in song screen menu that exits and mark the song broken. The information is stored in the database and can later be used for song filtering

Closes Issue(s)

#942

Motivation

Many songs from usdb are not synchronous so the are not performable. This is the first step to be able to filter out those songs. Later #868 will be extended to apply a filter for broken songs.

Testing

Actually there is nothing that the user can notice after a song is marked. Tests can only prove that the database.xml holds the broken flag. On Windows the database.xml ist found at C:\Users\<username>\AppData\Roaming\performous.

[github-actions[bot]]

Download the artifacts for this pull request:

• Performous-1.3.1-978-5c7d0f5-alpha-ubuntu_22.04.deb.zip
• Performous-1.3.1-978-5c7d0f5-alpha-debian_11.deb.zip
• Performous-1.3.1-978-5c7d0f5-alpha-fedora_35.rpm.zip
• Performous-1.3.1-978-5c7d0f5-alpha-fedora_37.rpm.zip
• Performous-1.3.1-978-5c7d0f5-alpha-fedora_36.rpm.zip
• Performous-1.3.1-978-5c7d0f5-alpha-fedora_38.rpm.zip
• Performous-1.3.1-978-5c7d0f5-alpha-debian_12.deb.zip
• Performous-1.3.1-978-5c7d0f5-alpha-debian_10.deb.zip
• Performous-1.3.1-978-5c7d0f5-alpha-fedora_39.rpm.zip
• Performous-1.3.1-978-5c7d0f5-alpha-ubuntu_20.04.deb.zip
• Performous-1.3.1-978-5c7d0f5-alpha.AppImage.zip
• Performous-1.3.1-978-5c7d0f5-alpha-msvc.exe.zip
• Performous-1.3.1-978-5c7d0f5-alpha.dmg.zip
• Performous-1.3.1-978-5c7d0f5-alpha-mingw-w64.exe.zip

This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.

[Baklap4]

Is this to be reviewed? Or is it still in draft phase?

[HetorusNL]

The implementation looks good to me. I would, however, suggest to rename 'Abort' to something more explicitly suggesting that this is 'marking the song as broken'.

Don't know if I'm necroing something, but the whole tabs vs spaces, what's the intended style for Performous? And if there is a style, it might be a good idea to (auto?) format all files and get it over with (and at the same time invalidating all PR's if github can't handie this..)

[twollgam]

I would, however, suggest to rename 'Abort' to something more explicitly suggesting that this is 'marking the song as broken'.

Any suggestions?

1. Abort cause defect
2. Abort defect song
3. Mark song defect and quit
4. ...

[twollgam]

Don't know if I'm necroing something, but the whole tabs vs spaces, what's the intended style for Performous? And if there is a style, it might be a good idea to (auto?) format all files and get it over with (and at the same time invalidating all PR's if github can't handie this..)

You mean indent? There is a PR for rejecting wrong formatted files locally. I think github gives no support server side. But a pipeline could fail for wrong formatted files.

[HetorusNL]

I would, however, suggest to rename 'Abort' to something more explicitly suggesting that this is 'marking the song as broken'.

Any suggestions?

1. Abort cause defect

2. Abort defect song

3. Mark song defect and quit

4. ...

Edit: There is also the Exit to song browser and mark song broken tooltip thingy, I forgot, in that case simply Abort might be good as well

Maybe something like: Quit (Song Defect) or even Quit (Defect) as the other menu options are also very short, but I'm not sure