f2e-spec Initialize SDL before creating threads to avoid concurrency issues

Fixes #946

Nov 27 '23 00:11 berarma

Thanks for the PR @berarma the pipelines are running to see if everything still builds on every system.

@ooshlablu can you repro the issue (on master) and see if this fixes it? (Debian 12) i'll do some testing with Windows later today

Nov 27 '23 07:11 Baklap4

Download the artifacts for this pull request:

This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.

Nov 27 '23 07:11 github-actions[bot]

I've changed the PR since I've found we can still load the cache file asynchronously if we init SDL before loading it.

Dec 02 '23 00:12 berarma

Was this issue platform-specific? I think it's weird that I never encountered it.

That aside, I think we should really update the nlohmann syntax on the cache code, I've been saying this for a while.

There's an .at method that has bounds-checking and would allow us better catching of exceptions. It was introduced I think in nlohmann 3.6 or something of the like. Way back when there waa pushback on this because of compatibility with distro packages, but I doubt that's an issue anymore?

Mar 28 '24 07:03 Lord-Kamina

@ooshlablu can you please test this one. If is it ok I will merge it.

Mar 28 '24 07:03 twollgam

Was this issue platform-specific?

Most probably. It's due to SDL changing the locale temporarily for calling a X11 function as reported in the related issue.

Mar 28 '24 09:03 berarma

Thanks for the PR, going to merge it :)

Mar 29 '24 11:03 Baklap4