f2e-spec possible fix of black cover

possible fix of black cover

Open twollgam opened this issue 1 year ago • 6 comments

trafficstars

What does this PR do?

Possible bugfix of #949

Closes Issue(s)

#949

Nov 26 '23 21:11 twollgam

Download the artifacts for this pull request:

This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.

Nov 26 '23 22:11 github-actions[bot]

I still have some "empty" covers like shown in the issue

@berarma how's this fix for you?

Nov 27 '23 07:11 Baklap4

In my laptop with Wayland the issue didn't happen. In my desktop computer it's working well with this fix.

@Baklap4 Do your covers turn empty after playing and exiting the song or are they empty from the start?

Nov 27 '23 08:11 berarma

These were empty from the start, but yesterday they still had an image... probably something weird on my system (i did delete all the cache and database.xml, but no dice)

Nov 27 '23 09:11 Baklap4

Before, it was the first song in the list that had no cover, but after playing a song, it was the last song played. Now it's always the first song in the list.

It seems that the first cover inserted into m_covers doesn't show up. Clearing m_covers just changes which song is the first. That's why I thought it was working at first. Now the last song played doesn't loose the cover, but it's always the first one in the list.

Dec 03 '23 19:12 berarma

Yes I think this one is also related to the texture management pr. I hope it is fixed in #955 too.

Dec 03 '23 22:12 twollgam

f2e-spec f2e-spec copied to clipboard

possible fix of black cover

What does this PR do?

Closes Issue(s)

f2e-spec
f2e-spec copied to clipboard