f2e-spec
f2e-spec copied to clipboard
Feature/commenttag
What does this PR do?
Trying to introduce new (hopefully) standardized fields.
This helps in distinguishing where the mapped file came from and which program made it at which version.
Aside from this #COMMENT
is sometimes used which is now also supported
Closes Issue(s)
None
Motivation
I'm trying to get a couple new standardized fields into the ultrastar format. This allows hosting websites to add their name to song files whilst creator tools like composer add their specific version and appname.
This way everyone knows where the txt came from and which program is used to create it.
Since the varying sources of which you can download songs from differ in quality this is a nicely added bonus to see where it came from.
Might be a niche for just me, but if everyone opts in it'd make for a way better system and maybe even a newly introduced system which combines all the sources out there.... (that's my endgoal)
Testing
You can test this by adding the following tags:
#SOURCE:USDB
#APP:Composer
#APPVERSION:1.0.0
#COMMENT:Some comment
All tags are opt in. But if everyone plays by the rules every txt will have these fields eventually
The tags are shown within the webserver-ui: Playlist and search screen.
All extra tags are seperated by the |
symbol. And the popup if you click a song also mentions the tags + content if they're there.
Meanwhile...
Meanwhile i'm trying to convince other karaoke creators and downloadable websites to implement this for every song txt they have. But currently everyone is against it....
Still a draft since i haven't tested it yet
Download the artifacts for this pull request:
- Performous-1.3.0-883-940494f-alpha.AppImage.zip
- Performous-1.3.0-883-940494f-alpha.dmg.zip
- Performous-1.3.0-883-940494f-alpha-debian_10.deb.zip
- Performous-1.3.0-883-940494f-alpha-debian_11.deb.zip
- Performous-1.3.0-883-940494f-alpha-debian_12.deb.zip
- Performous-1.3.0-883-940494f-alpha-fedora_35.rpm.zip
- Performous-1.3.0-883-940494f-alpha-fedora_36.rpm.zip
- Performous-1.3.0-883-940494f-alpha-fedora_37.rpm.zip
- Performous-1.3.0-883-940494f-alpha-fedora_38.rpm.zip
- Performous-1.3.0-883-940494f-alpha-mingw-w64.exe.zip
- Performous-1.3.0-883-940494f-alpha-msvc.exe.zip
- Performous-1.3.0-883-940494f-alpha-ubuntu_20.04.deb.zip
- Performous-1.3.0-883-940494f-alpha-ubuntu_22.04.deb.zip
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.
Undrafted this. Ready for review :) Also updated the Original post
Waiting for finalizing: https://github.com/UltraStar-Deluxe/format/issues/35
The gods have decided. A new tag is introduced to credit hosting website. The key is: #PROVIDEDBY
See: https://github.com/UltraStar-Deluxe/format/issues/35#issuecomment-1819221345
Will fix this in a next commit
Was replaced by https://github.com/performous/performous/pull/975 since github didn't let me refresh this PR.... kind of weird...