f2e-spec icon indicating copy to clipboard operation
f2e-spec copied to clipboard

Webserver: Dark-green theme missing resources (but also performous bug).

Open Lord-Kamina opened this issue 3 years ago • 2 comments

Performous & operating system versions

Performous master + PR OS: macOS 15

What is the problem?

I'm working on tidying up my take of the webserver rework, and I noticed a bug on the handling of theme resources. The dark-green theme currently has a broken web interface. The reason is probably how we're handling resource paths.

We're currently building our theme folders as follows:

	Paths infixes = { 
		themes / theme,
		themes / theme / www,
		themes / theme / www / js,
		themes / theme / www / css,
		themes / theme / www / images,
		themes / theme / www / fonts,

		themes / def,
		themes / def / www,
		themes / def / www / js,
		themes / def / www / css,
		themes / def / www / images,
		themes / def / www / fonts,
		fs::path() };
	if (!theme.empty() && theme != def) infixes.push_front(themes / theme);

The theme has a custom style.css, so the css folder is not empty, and thus performous fails to find the bootstrap files. Expected behavior would be for our fallback mechanism to work as the file level, rather than the folder level.

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

Lord-Kamina avatar Sep 20 '22 10:09 Lord-Kamina

So basicly you're suggesting to fallback onto the default theme if some file is not modified within the new theme?

In this instance, bootstrap from the default theme should be used right?

Baklap4 avatar Sep 21 '22 08:09 Baklap4

I am, but put this on hold. I'm experiencing some other issue that could also be the cause for this.

Lord-Kamina avatar Sep 21 '22 09:09 Lord-Kamina