f2e-spec icon indicating copy to clipboard operation
f2e-spec copied to clipboard

Published 20 hours ago • verified publisher icon alibaba

Save timestamp with high score

Open BWagener opened this issue 3 years ago • 6 comments

Suggestion

Having a timestamp for each high score is a feature I think would be cool.

Use case

Being able to see your progress over time when practicing a song is a great motivation.

This kind of relates to https://github.com/performous/performous/issues/11. A feature like this would also tie well into https://github.com/performous/performous/issues/11, allowing charting average overall score or score by song over time at some point.

Extra info/examples/attachments

No response

BWagener avatar Sep 07 '22 06:09 BWagener

Looks like a really nice feature and indeed ties well into 11! Charting the scores can maybe be done within the web ui instead of in performous (or both). Web is more easy to realise some charts i think ;P

Baklap4 avatar Sep 07 '22 07:09 Baklap4

For visualization I was thinking web as well!

I accidentally linked the same issue twice. I meant to also refer to https://github.com/performous/performous/issues/240, I also found https://github.com/performous/performous/issues/53 which is related.

Another one I found which is probably obsolete is https://github.com/performous/performous/issues/103

BWagener avatar Sep 07 '22 11:09 BWagener

So the current database.xml is an xml file + it also comes with some flaws. We can think this over and just use json for this. Then again we won't get rid of libxmlpp since we also have a xml parser... for singstar discs... last time i heard @Lord-Kamina about this and it was pretty skeptical if someone even uses this format nowadays

Baklap4 avatar Sep 07 '22 15:09 Baklap4

Performance would likely be a trivial difference if any at all, but if we were to switch it to JSON, the API is so much simpler to work with IMO.

For visualization (I can already see you groaning) but I'd consider bringing in a simple graphing lib. Otherwise, what would you do, HTML5?

Lord-Kamina avatar Sep 07 '22 16:09 Lord-Kamina

Also, my reasoning for being is skeptical is that most likely anybody who would import Singstar songs most likely already did it by now.

Lord-Kamina avatar Sep 07 '22 16:09 Lord-Kamina

Yeah for visualizations we probably can use chart.js (a library which is commonly used) The json api is way easier/cleaner to work with you're correct!

Baklap4 avatar Sep 07 '22 16:09 Baklap4

@Baklap4 @BWagener the issue is closed automagic by github. I am not sure if that is ok cause maybe not everything is included in #857.

twollgam avatar Mar 08 '23 20:03 twollgam