f2e-spec
f2e-spec copied to clipboard
fix showing highscore input player name with instruments
What does this PR do?
adding again the screen at the end of a song for the highscore with instrument not only with vocal
Motivation
i usually use with with instrument and almost never for sing, so it was frustrating not having any highscore
Additional Notes
i only tested it with few songs with and without vocal and it seems to be working i had to edit the getVocalTrack function otherwise it will crash on track without vocal
Download the artifacts for this pull request:
- Performous-1.2.0-803-1f37f3b-alpha.AppImage.zip
- Performous-1.2.0-803-1f37f3b-alpha.dmg.zip
- Performous-1.2.0-803-1f37f3b-alpha.exe.zip
- Performous-1.2.0-803-1f37f3b-alpha-debian_10.deb.zip
- Performous-1.2.0-803-1f37f3b-alpha-debian_11.deb.zip
- Performous-1.2.0-803-1f37f3b-alpha-fedora_34.rpm.zip
- Performous-1.2.0-803-1f37f3b-alpha-fedora_35.rpm.zip
- Performous-1.2.0-803-1f37f3b-alpha-fedora_36.rpm.zip
- Performous-1.2.0-803-1f37f3b-alpha-ubuntu_18.04.deb.zip
- Performous-1.2.0-803-1f37f3b-alpha-ubuntu_20.04.deb.zip
- Performous-1.2.0-803-1f37f3b-alpha-ubuntu_22.04.deb.zip
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.
Please split the dark-green theme into a separate PR
Please split the dark-green theme into a separate PR
sorry i've made a little mess with the commit and branches, i think i've fixed it!!
@Darkmagister Can you rebase this to current master and fix the conflicts? I'll be able to test it when it's updated, hopefully we'll get it merged quickly.