f2e-spec icon indicating copy to clipboard operation
f2e-spec copied to clipboard

fix showing highscore input player name with instruments

Open Darkmagister opened this issue 2 years ago • 3 comments

What does this PR do?

adding again the screen at the end of a song for the highscore with instrument not only with vocal

Motivation

i usually use with with instrument and almost never for sing, so it was frustrating not having any highscore

Additional Notes

i only tested it with few songs with and without vocal and it seems to be working i had to edit the getVocalTrack function otherwise it will crash on track without vocal

Darkmagister avatar Aug 03 '22 21:08 Darkmagister

Please split the dark-green theme into a separate PR

Baklap4 avatar Aug 10 '22 14:08 Baklap4

Please split the dark-green theme into a separate PR

sorry i've made a little mess with the commit and branches, i think i've fixed it!!

Darkmagister avatar Aug 10 '22 15:08 Darkmagister

@Darkmagister Can you rebase this to current master and fix the conflicts? I'll be able to test it when it's updated, hopefully we'll get it merged quickly.

ooshlablu avatar Dec 31 '22 19:12 ooshlablu