f2e-spec icon indicating copy to clipboard operation
f2e-spec copied to clipboard

Some songs end with a very strange score at the end which causes a crash in Debug builds

Open ooshlablu opened this issue 3 years ago • 4 comments

Performous & operating system versions

1.2.0+ (reproducible on current master linked in the README, not sure where it started) Reproducible on any OS that you can use the guitar controller on.

What is the problem?

The song seems to play fine and everything until the very end where it appears to reveal 2 scores: The final score you got while playing guitar, and a very strange score in the very deep negative billions: Screenshot_from_2022-05-18_13-01-38

This does not cause a crash on release builds, but causes a crash on debug builds.

Steps to reproduce

So far, I have only been able to reproduce this using guitar, specifically, on any difficulty level. I have not been able to reproduce this this on bass or vocals. It can be reproduces every time by skipping to the end of https://brewaces-public.s3.us-east-2.amazonaws.com/take_the_money.tgz and playing the very last chord.

Additional Screenshots

The crash: Can't dereference out of range vector iterator image

Last point from our application running into this issue: https://github.com/performous/performous/blob/master/game/guitargraph.cc#L443

Values from the ptr in question image

Log(s) & preferences file(s)

No response

ooshlablu avatar May 18 '22 19:05 ooshlablu

-2147483648 is 0xFFFFFFFF80000000 in hex, and 0x80000000 is nan in float IIRC. could be some messed up conversion somewhere or failed test against nan

OznOg avatar May 19 '22 07:05 OznOg

Is this still the case @ooshlablu ? i think i saw some merges regarding libfmt which has caused this issue to begin with.

Baklap4 avatar Aug 01 '22 08:08 Baklap4

@Baklap4 I've noticed recently that the strange score is no longer there in recent builds. Instead, the score drops to all zeros :-) I'm wondering if the crash is still present in the debug builds.

ooshlablu avatar Sep 08 '22 19:09 ooshlablu

@ooshlablu the crash in debug builds is still pressent

Baklap4 avatar Sep 15 '22 18:09 Baklap4