f2e-spec
f2e-spec copied to clipboard
alibaba
Rework webserver
What does this PR do?
This enable webserver for all people using cpp-httplib that is easier to install (no dependency)
Additional Notes
There is still a fix to do in the CMake file in order to fetch it from a clone of cpp-httplib that we'll have on performous project.
Closes
Closes #603 Closes #452 Closes #623 Closes #517 (if https://github.com/performous/performous/pull/766#discussion_r875235203 is answered)
I can't test until I get my laptop back. That being said, there are some things from my PR that I would very much like to see here, such as:
- Refactoring in mime-type handling
- Decoupling of the search between the webserver UI and the game's actual interface.
- Ability to connect to webserver from local network only (i.e. define a subnet mask that allows more than localhost, but doesn't leave the computer open to the world)
There might be others, but that's what I remember now.
Also, I'm still not fully convinced that using a synchronous library will really work as expected.
That being said, there are some things from my PR that I would very much like to see here, such as:
- Refactoring in mime-type handling
- Decoupling of the search between the webserver UI and the game's actual interface.
- Ability to connect to webserver from local network only (i.e. define a subnet mask that allows more than localhost, but doesn't leave the computer open to the world)
I think it'd be wise to add this into separate pr's as this pr is currently only porting to another library
Download the artifacts for this pull request:
- Performous-1.2.0-766-b61997c-alpha.AppImage.zip
- Performous-1.2.0-766-b61997c-alpha-debian_10.deb.zip
- Performous-1.2.0-766-b61997c-alpha-debian_11.deb.zip
- Performous-1.2.0-766-b61997c-alpha-fedora_34.rpm.zip
- Performous-1.2.0-766-b61997c-alpha-fedora_35.rpm.zip
- Performous-1.2.0-766-b61997c-alpha-fedora_36.rpm.zip
- Performous-1.2.0-766-b61997c-alpha-ubuntu_18.04.deb.zip
- Performous-1.2.0-766-b61997c-alpha-ubuntu_20.04.deb.zip
- Performous-1.2.0-766-b61997c-alpha-ubuntu_22.04.deb.zip
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
That being said, there are some things from my PR that I would very much like to see here, such as:
- Refactoring in mime-type handling
- Decoupling of the search between the webserver UI and the game's actual interface.
- Ability to connect to webserver from local network only (i.e. define a subnet mask that allows more than localhost, but doesn't leave the computer open to the world)
I think it'd be wise to add this into separate pr's as this pr is currently only porting to another library
What about the subnet thing? I'm looking into whether httplib supports it at all but I can't find any info.
Added both #603 & #452 as linked issues as these will be closed by merging this.
Converting this PR to draft status since it's outdated, got merge conflicts and has some open discussions.
@yoda-jm any objections that i take over this branch so i can make it up to date again?
@yoda-jm any objections that i take over this branch so i can make it up to date again?
Please go ahead :)