f2e-spec Player screen

What does this PR do?

Add a new screen for player management.

Closes Issue(s)

#574

Motivation

The current player management is very basic. With this PR one can manage players ingame.

Tasks

[x] Add a new player.
[x] Delete a player.
[ ] Delete player scores.
[ ] Display avatar on score screen.
[ ] Tune layout.
[x] Graphical effect for focus
[x] Draw cursor in textbox instead pipe inside text

May 07 '22 10:05 twollgam

@twollgam feel free to share some screenshots of the proposed screen so we can talk about that in here instead of pinpointing the code responsable for that

May 11 '22 08:05 Baklap4

@Baklap4 here are three screenshots. They show how focus is visualized. Some features are missing, fe adding new players. Screenshot_Performous_Players-1

May 11 '22 21:05 twollgam

Download the artifacts for this pull request:

This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.

May 16 '22 23:05 github-actions[bot]

I'm missing a way to add/remove players

As for designs: Avatar choice: Maybe hook up into the webcam to take a picture? Checkbox behind name: what is it used for? I'm assuming to enable the player for singing which you set up once at the start Optional feature: Match a singer's microphone (color) to an avatar

I'm not particularly fond of the background color showing the bounds of the list of names. I think this can be transparent, with optional a scrollbar when the list is overflowing

navigation in the window is kinda wonky with only keyboard input maybe mouse support would be nice

May 18 '22 16:05 Baklap4

Commited "Add player" and "Remove player".
Webcam would be nice. Maybe not for the first version. (I did not own a webcam, so it would be difficult to implement it).
Mic colors: I currently have no idea how to do this.
Mouse? Can it be used? I think there is no mouse support yet and performous is keyboard only. Shortcuts?

May 20 '22 17:05 twollgam

@twollgam @marwin89 avatar collection of yours would be very nice 👍

Oct 06 '23 11:10 Baklap4

This is the current (transparent) version of my ultrastar-vocaluxe-avatar-collection.

I'm not quite sure if you can integrate it directly in performous because of license questions (GNU GPLv2?) (AI-generated etc). so I would recommend now treating it as a add-on and just link to my repository. And then we'll see.

SongScreen

Oct 13 '23 08:10 marwin89

@marwin89 I would like to replace the current avatars with yours, cause I read "free for open source". Did I misunderstand that?

Oct 13 '23 18:10 twollgam

Yes u can integrate it in the game, if its compatabile with GNU GPLv2 License of performous. It's just: I'm no license expert when it comes to ai-generated content and GNU GPLv2.

My Add-on is free for open source but I have to include CreativeML Open RAIL-M license in my package cause I used getimg.ai. And I dont know if this Open RAIL-M license causes inconsistencies with performous license. My first time with AI 💻 😄

But I guess its fine if you just include this readme and license.txt in the profile pic folder. 👍 🎉

Oct 14 '23 11:10 marwin89

@twollgam btw thank you for doing this player screen 🚀 🎸 This will improve the game a lot

Oct 15 '23 17:10 marwin89

Yes u can integrate it in the game, if its compatabile with GNU GPLv2 License of performous. It's just: I'm no license expert when it comes to ai-generated content and GNU GPLv2.

My Add-on is free for open source but I have to include CreativeML Open RAIL-M license in my package cause I used getimg.ai. And I dont know if this Open RAIL-M license causes inconsistencies with performous license. My first time with AI 💻 😄

But I guess its fine if you just include this readme and license.txt in the profile pic folder. 👍 🎉

@marwin89 How did you create the images? If you only have converted text to image with stable diffusion, I think we cannot use the images in performous cause we do not know if there is an owner of an image. If someone has the origin and it can be recognized from one of the generated we have a licence problem. @Baklap4 what do you think?

Oct 15 '23 19:10 twollgam

How did you create the images? If you only have converted text to image with stable diffusion, I think we cannot use the images in performous cause we do not know if there is an owner of an image. If someone has the origin and it can be recognized from one of the generated we have a licence problem.

@twollgam I created the images via text-to-image on getimage.ai with dreamshaperv7 (a stable diffusion model). It's highly unlikely that the model just copies the work of an artist. Its a complex combination of features that produces "new art" and I have to do a lot to make meaningful pictures of the random outputs. It's 30 prompts to get something.

I Just learned: the problem with stable diffussion is, that they trained their models with billions of images without asking or paying the artists. So they get troubles and are sued (no decision yet).

I tought the "fair use"-argument in the USA would justify (like:

I don't get money from it,
don't harm the career of artists,
don't claim copyright, say its ai-generated
just make usage restriction
pay for the usage of the tool But there is no final decision.

My conclusion:

I don't wanna get in trouble and wait for a regulation, so I make the repository private and take it down for now.
Maybe I find an AI-Tool that is copyright safe.

Oct 16 '23 17:10 marwin89

Good decision to be safe IMO. Sad for me and performous.

The only safe way I can imagine is to search for CC0 images and let an ai do some work on those. But that is much more work to do.

Oct 16 '23 17:10 twollgam

Good decision to be safe IMO. Sad for me and performous.

Yes it's sad indeed 😞 I had so many ideas and even made this mock-up for performous with bigger avatars...

preview-mockup-performous-profiles-2024

Oct 16 '23 19:10 marwin89

The only safe way I can imagine is to search for CC0 images and let an ai do some work on those. But that is much more work to do.

This is a good Idea. I made some research. 😄 Good News: This way could work:

free images from pexels under pexels license (from trustworthy sources, all documented, with links, "copyright"-folder, no VIPs, no famous persons)
combined with copyright free cartoon effekt filter "Badlands" from picsart editor (I pay pricing).

@Baklap4 , @twollgam : is this acceptable for you? I guess its the safest way (legally) 🚀

Here is a mockup for player select. Do you like that art style?

mockup-performous-profiles-2024-(pexel-picsart)

Oct 17 '23 14:10 marwin89

Would be good to keep the original images with notes of source and license in a repository. If the license is CC0 or something equal (no attribution for example) we should be able to use the modified pictures. @Baklap4 what do you think?

BTW pixabay.com could be a source for images.

Oct 17 '23 21:10 twollgam

Would be good to keep the original images with notes of source and license in a repository.

thats a good idea. 💡 👍 👍

If the license is CC0 or something equal (no attribution for example) we should be able to use the modified pictures.

Thats great cause Pexels license is without attribution. It's similiar to pixabay. really cool 🎉

BTW pixabay.com could be a source for images.

Yess! pixabay its a good source for many things yet it seems to me that musicians stock photos are more on pexels (after research). 📷

Oct 18 '23 12:10 marwin89

Would be good to keep the original images with notes of source and license in a repository. If the license is CC0 or something equal (no attribution for example) we should be able to use the modified pictures. @Baklap4 what do you think?

BTW pixabay.com could be a source for images.

I think that's alright yes 👍

Love the design and time you put into this @marwin89 !

Oct 20 '23 12:10 Baklap4

Would be good to keep the original images with notes of source and license in a repository.

Hi @twollgam, @Baklap4 , 👋

I made a draft repository for the avatars.
When you agree we can move it to performous as a sub-repository.
copyright section is completed.
https://github.com/marwin89/performous-avatars-official
let me know if you got some ideas. 💡 🚀

have a nice day

performous-avatars-2024-official-preview

Oct 23 '23 08:10 marwin89

Avatars 2024 are now officially moved to performous organization: https://github.com/performous/performous-avatars-official 🎉
I made a seperate Issue for improving player config screen, so tobias can concentrate on finishing this pull-request and the original Issue 🙏
#931

Nov 01 '23 08:11 marwin89

f2e-spec f2e-spec copied to clipboard

Player screen

What does this PR do?

Closes Issue(s)

Motivation

Tasks

f2e-spec
f2e-spec copied to clipboard