f2e-spec icon indicating copy to clipboard operation
f2e-spec copied to clipboard

Building without webserver support, still shows menu entry

Open Baklap4 opened this issue 5 years ago • 3 comments

Do you want to request a feature or report a bug?

Bug

I've just installed a new version of debian, and installed the bare minimum dependencies using:

sudo apt install git cmake build-essential gettext help2man libopenblas-dev libfftw3-dev libicu-dev libepoxy-dev libsdl2-dev libfreetype6-dev libpango1.0-dev librsvg2-dev libxml++2.6-dev libavcodec-dev libavformat-dev libswscale-dev libjpeg-dev portaudio19-dev libglm-dev libboost-all-dev

This results in a build where webserver support is not supported since cpprestsdk is not found.

However in the menu i can still disable/enable the webserver (it does nothing though)

What did you expect to see?

I didnt expect to see webserver features in game.

What did you see instead?

I saw webserver features in game.

Output of performous --version: (What version of Performous are you using?)

Latest master

What is your environment & configuration (arguments, platform, ...)?

Debian 10

Baklap4 avatar Mar 28 '20 22:03 Baklap4

This should be easy to fix, it's probably a bug in the CMakeLists.txt

Lord-Kamina avatar Mar 28 '20 23:03 Lord-Kamina

Todo

  • [ ] Wait for #545 OR
  • [x] Fix menu by checking USE_WEBSERVER

Baklap4 avatar Aug 15 '21 19:08 Baklap4

With the current (2022-05-17) state of #766 the webserver becomes part of the core system and thus invalidating this issue.

Baklap4 avatar May 17 '22 21:05 Baklap4

Still happening as of 26-11-2023. Let's fix this the easy way by checking USE_WEBSERVER

Baklap4 avatar Nov 26 '23 14:11 Baklap4