alibaba
Use the instrumental track on enabling audio/mute_vocals_track when available
What does this PR do?
Performous stores the instrumental tracks as defined by the most recent UltraStar format specification, however, at the moment, it's not in use. At the same time, the setting audio/mute_vocals_track remains unused whenever the UltraStar text files are used. This pull request attempts to rectify this.
Additional Notes
In order to enable instrumental tracks to be stored on a song, the caching JSON had to be modified to add the instrumental file location. This part should completely be non-breaking, though requires a cache refresh.
In theory, this pull request shouldn't break Frets on Fire and / or StepMania support, this has yet to be tested, but I assume there won't be a problem, as the "Instrumental" track is only used on UltraStar text files.
@ooshlablu can you give this a test run?
@GaryCXJk Thanks for the PR, Codewise it looks alright but i haven't tested it myself yet
Download the artifacts for this pull request:
- Performous-1.3.1+git-3e210c0-PR1051-alpha-arm64.dmg.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-msvc.exe.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-fedora_40.rpm.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-fedora_42.rpm.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-fedora_39.rpm.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-fedora_41.rpm.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-fedora_36.rpm.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-ubuntu_24.04.deb.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-fedora_38.rpm.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-fedora_37.rpm.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-ubuntu_20.04.deb.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-ubuntu_22.04.deb.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-debian_12.deb.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha.AppImage.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-x86_64.dmg.zip
- Performous-1.3.1+git-3e210c0-PR1051-alpha-mingw-w64.exe.zip
This service is provided by nightly.link. These artifacts will expire in 90 days and will not be available for download after that time.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Baklap4 I test on Ubuntu 24.04 with guitar + vocals at the same time and these changes don't interfere with any of the sources I have, which is mostly FoFix/Phaseshift/Clonehero format. I don't have any Ultrastar songs at all tho, even without instruments, so I can't really speak for the changes. Didn't break anything for me tho :-)
